From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754289AbcEPR0G (ORCPT <rfc822;w@1wt.eu>);
	Mon, 16 May 2016 13:26:06 -0400
Received: from foss.arm.com ([217.140.101.70]:47693 "EHLO foss.arm.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753485AbcEPR0F (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 16 May 2016 13:26:05 -0400
Subject: Re: [RFC][PATCH 4/7] sched: Replace sd_busy/nr_busy_cpus with
 sched_domain_shared
To: Peter Zijlstra <peterz@infradead.org>
References: <20160509104807.284575300@infradead.org>
 <20160509105210.642395937@infradead.org> <5739E7BC.70205@arm.com>
 <20160516170257.GU3192@twins.programming.kicks-ass.net>
Cc: mingo@kernel.org, linux-kernel@vger.kernel.org, clm@fb.com,
        matt@codeblueprint.co.uk, mgalbraith@suse.de, tglx@linutronix.de,
        fweisbec@gmail.com
From: Dietmar Eggemann <dietmar.eggemann@arm.com>
Message-ID: <573A02A8.8030501@arm.com>
Date: Mon, 16 May 2016 18:26:00 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.6.0
MIME-Version: 1.0
In-Reply-To: <20160516170257.GU3192@twins.programming.kicks-ass.net>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 16/05/16 18:02, Peter Zijlstra wrote:
> On Mon, May 16, 2016 at 04:31:08PM +0100, Dietmar Eggemann wrote:
>> On 09/05/16 11:48, Peter Zijlstra wrote:
>>
>> Couldn't you just always access sd->shared via
>> sd = rcu_dereference(per_cpu(sd_llc, cpu)) for
>> updating nr_busy_cpus?
> 
> Sure; but why would I want to add that extra dereference? Note that in
> the next patch I add more users of sd_llc_shared.
> 

I see ... I thought because you do this already in
set_cpu_sd_state_[busy|idle]. But there you need the sd reference to set
sd->nohz_idle already.