From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933519AbcEQBuT (ORCPT ); Mon, 16 May 2016 21:50:19 -0400 Received: from mail-pa0-f68.google.com ([209.85.220.68]:36779 "EHLO mail-pa0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754251AbcEQBuN (ORCPT ); Mon, 16 May 2016 21:50:13 -0400 Subject: Re: [PATCH v2 2/2] pci: host: Add Broadcom STB PCIE RC controller To: Bharat Kumar Gogada , "linux-pci@vger.kernel.org" References: <1462475700-1654-1-git-send-email-f.fainelli@gmail.com> <1462475700-1654-3-git-send-email-f.fainelli@gmail.com> <8520D5D51A55D047800579B094147198258955D9@XAP-PVEXMBX01.xlnx.xilinx.com> Cc: "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "bcm-kernel-feedback-list@broadcom.com" , "jim2101024@gmail.com" , "bhelgaas@google.com" , "arnd@arndb.de" From: Florian Fainelli Message-ID: <573A78D0.9090000@gmail.com> Date: Mon, 16 May 2016 18:50:08 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <8520D5D51A55D047800579B094147198258955D9@XAP-PVEXMBX01.xlnx.xilinx.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/11/2016 07:47 AM, Bharat Kumar Gogada wrote: [snip] >> + /* Get the value for the log2 of the scb sizes. Subtract 15 from >> + * each because the target register field has 0==disabled and 1==6KB. >> + */ >> + log2_scb_sizes = of_get_property(dn, "brcm,log2-scb-sizes", &rlen); >> + if (log2_scb_sizes) { >> + for (i = 0; i < rlen / sizeof(u32); i++) { >> + pcie->scb_size_vals[i] >> + = (int)of_read_number(log2_scb_sizes + i, 1) >> + - 15; >> + pcie->num_memc++; >> + } >> + } > In your device tree documentation this is required property, what if this property > is missing ? If you look at the driver, you will see that it assumes a 1GB SCB window size if this property is absent. PS: Do you mind trimming your replies in the future just to quote the relevant part? Pretty much like I just did, this greatly improves the ability to jump right to where the comments are. Thanks -- Florian