From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755277AbcEQFOr (ORCPT ); Tue, 17 May 2016 01:14:47 -0400 Received: from mx2.suse.de ([195.135.220.15]:40095 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752626AbcEQFOq (ORCPT ); Tue, 17 May 2016 01:14:46 -0400 Subject: Re: Question About Functions "__free_pages_check" and "check_new_page" in page_alloc.c To: Wang Xiaoqiang , Michal Hocko , n-horiguchi , linux-kernel , linux-mm References: <7374bd2e.da35.154b9cda7d2.Coremail.wang_xiaoq@126.com> <20160516151657.GC23251@dhcp22.suse.cz> <5877fe6c.1e45.154bc401c81.Coremail.wang_xiaoq@126.com> From: Vlastimil Babka Message-ID: <573AA8C2.2060606@suse.cz> Date: Tue, 17 May 2016 07:14:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.0 MIME-Version: 1.0 In-Reply-To: <5877fe6c.1e45.154bc401c81.Coremail.wang_xiaoq@126.com> Content-Type: text/plain; charset=gbk Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/17/2016 03:06 AM, Wang Xiaoqiang wrote: >>yes it would. Why that would matter. The checks should be in an order >>which could give us a more specific reason with later checks. bad_page() > > I see, you mean the later "bad_reason" is the superset of the previous one. Not exactly. It's not possible to sort all the reasons like that. But as Michal said, bad_page() will print all the relevant info so you can reconstruct all reasons from it. The bad_reason text is mostly a hint what to check first. >>will then print more detailed information. >>-- >>Michal Hocko >>SUSE Labs > > thank you, Michal. > > > >