From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754501AbcEQHiL (ORCPT ); Tue, 17 May 2016 03:38:11 -0400 Received: from mga04.intel.com ([192.55.52.120]:52416 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753983AbcEQHiK (ORCPT ); Tue, 17 May 2016 03:38:10 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,324,1459839600"; d="scan'208";a="978512810" Subject: Re: [PATCH v3 1/7 UPDATE] perf tools: Find vdso with the consider of cross-platform To: Arnaldo Carvalho de Melo , He Kuang References: <573455BA.1070707@intel.com> <1463129509-160934-1-git-send-email-hekuang@huawei.com> <20160516133240.GC5475@kernel.org> Cc: peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, jolsa@redhat.com, wangnan0@huawei.com, jpoimboe@redhat.com, ak@linux.intel.com, eranian@google.com, namhyung@kernel.org, sukadev@linux.vnet.ibm.com, masami.hiramatsu.pt@hitachi.com, tumanova@linux.vnet.ibm.com, kan.liang@intel.com, penberg@kernel.org, dsahern@gmail.com, linux-kernel@vger.kernel.org From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: <573AC972.1080104@intel.com> Date: Tue, 17 May 2016 10:34:10 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <20160516133240.GC5475@kernel.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/05/16 16:32, Arnaldo Carvalho de Melo wrote: > Em Fri, May 13, 2016 at 08:51:49AM +0000, He Kuang escreveu: >> There's a problem in machine__findnew_vdso(), vdso buildid generated >> by a 32-bit machine stores it with the name 'vdso', but when >> processing buildid on a 64-bit machine with the same 'perf.data', perf >> will search for vdso named as 'vdso32' and get failed. >> >> This patch tries to find the exsiting dsos in machine->dsos by thread >> dso_type. 64-bit thread tries to find vdso with name 'vdso', because >> all 64-bit vdso is named as that. 32-bit thread first tries to find >> vdso with name 'vdso32' if this thread was run on 64-bit machine, if >> failed, then it tries 'vdso' which indicates that the thread was run >> on 32-bit machine when recording. > > Adrian, are you ok now? I sent a couple more comments.