From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932325AbcEQHn5 (ORCPT ); Tue, 17 May 2016 03:43:57 -0400 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:35775 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752520AbcEQHnz (ORCPT ); Tue, 17 May 2016 03:43:55 -0400 Subject: Re: [PATCH] pinctrl: stm32: fix debugfs format string To: Arnd Bergmann , Linus Walleij References: <1463147643-568615-1-git-send-email-arnd@arndb.de> CC: Maxime Coquelin , Laxman Dewangan , Irina Tirdea , , , From: Patrice Chotard Message-ID: <573ACB96.6030808@st.com> Date: Tue, 17 May 2016 09:43:18 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <1463147643-568615-1-git-send-email-arnd@arndb.de> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.48.1.66] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-05-17_03:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnd I have already send a fix for this on the mailing list on 12th may ([PATCH 0/2] pinctrl: stm32: .pin_config_dbg_show fixes). I don't know if Linus will merged it on his pinctrl branch. Sorry Patrice On 05/13/2016 03:53 PM, Arnd Bergmann wrote: > The newly added stm32_pconf_dbg_show function has an incorrect format > string that does not match the arguments, as reported by the gcc warning: > > drivers/pinctrl/stm32/pinctrl-stm32.c: In function 'stm32_pconf_dbg_show': > drivers/pinctrl/stm32/pinctrl-stm32.c:797:17: error: too many arguments for format [-Werror=format-extra-args] > > This changes the format string in a way that gets rid of the warning. > > Signed-off-by: Arnd Bergmann > Fixes: 3beed93c1617 ("pinctrl: stm32: Implement .pin_config_dbg_show()") > --- > I could not find a documentation for the debugfs format, so no > idea if this is the intended format. > --- > drivers/pinctrl/stm32/pinctrl-stm32.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/stm32/pinctrl-stm32.c b/drivers/pinctrl/stm32/pinctrl-stm32.c > index e51c1cf5270b..4ffbe9551299 100644 > --- a/drivers/pinctrl/stm32/pinctrl-stm32.c > +++ b/drivers/pinctrl/stm32/pinctrl-stm32.c > @@ -794,7 +794,7 @@ static void stm32_pconf_dbg_show(struct pinctrl_dev *pctldev, > case 2: > drive = stm32_pconf_get_driving(bank, offset); > speed = stm32_pconf_get_speed(bank, offset); > - seq_printf(s, "%d - %s -%s", alt, > + seq_printf(s, "%d - %s - %s - %s %s ", alt, > drive ? "open drain" : "push pull", > biasing[bias], > speeds[speed], "speed");