From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932068AbcEQLwa (ORCPT ); Tue, 17 May 2016 07:52:30 -0400 Received: from www62.your-server.de ([213.133.104.62]:56614 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754606AbcEQLw2 (ORCPT ); Tue, 17 May 2016 07:52:28 -0400 Message-ID: <573B05F3.7000009@iogearbox.net> Date: Tue, 17 May 2016 13:52:19 +0200 From: Daniel Borkmann User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Yang Shi , ast@kernel.org, davem@davemloft.net CC: will.deacon@arm.com, catalin.marinas@arm.com, zlim.lnx@gmail.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linaro-kernel@lists.linaro.org Subject: Re: [PATCH v2 net-next] bpf: arm64: remove callee-save registers use for tmp registers References: <1463441786-32224-1-git-send-email-yang.shi@linaro.org> In-Reply-To: <1463441786-32224-1-git-send-email-yang.shi@linaro.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/17/2016 01:36 AM, Yang Shi wrote: > In the current implementation of ARM64 eBPF JIT, R23 and R24 are used for > tmp registers, which are callee-saved registers. This leads to variable size > of JIT prologue and epilogue. The latest blinding constant change prefers to > constant size of prologue and epilogue. AAPCS reserves R9 ~ R15 for temp > registers which not need to be saved/restored during function call. So, replace > R23 and R24 to R10 and R11, and remove tmp_used flag to save 2 instructions for > some jited BPF program. > > CC: Daniel Borkmann > Acked-by: Zi Shen Lim > Signed-off-by: Yang Shi LGTM, thanks! Acked-by: Daniel Borkmann