From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754166AbcEQNox (ORCPT ); Tue, 17 May 2016 09:44:53 -0400 Received: from mail-lf0-f45.google.com ([209.85.215.45]:33400 "EHLO mail-lf0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751643AbcEQNov (ORCPT ); Tue, 17 May 2016 09:44:51 -0400 Subject: Re: [PATCH V7 07/11] pci, acpi: Handle ACPI companion assignment. To: Dongdong Liu , helgaas@kernel.org, arnd@arndb.de, will.deacon@arm.com, catalin.marinas@arm.com, rafael@kernel.org, hanjun.guo@linaro.org, Lorenzo.Pieralisi@arm.com, okaya@codeaurora.org, jchandra@broadcom.com References: <1462893601-8937-1-git-send-email-tn@semihalf.com> <1462893601-8937-8-git-send-email-tn@semihalf.com> <573A8BED.7030908@huawei.com> Cc: robert.richter@caviumnetworks.com, mw@semihalf.com, Liviu.Dudau@arm.com, ddaney@caviumnetworks.com, wangyijing@huawei.com, Suravee.Suthikulpanit@amd.com, msalter@redhat.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linaro-acpi@lists.linaro.org, jcm@redhat.com, andrea.gallo@linaro.org, dhdang@apm.com, jeremy.linton@arm.com, cov@codeaurora.org, Linuxarm From: Tomasz Nowicki Message-ID: <573B204F.9040001@semihalf.com> Date: Tue, 17 May 2016 15:44:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Firefox/38.0 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <573A8BED.7030908@huawei.com> Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17.05.2016 05:11, Dongdong Liu wrote: > Hi Tomasz > > I used the patchset and added "PATCH V6 11/13 specic quirks", tested on > HiSilicon D02 board but met the below problem. > > [ 2.614115] [] hisi_pcie_init+0x6c/0x1ec > [ 2.619571] [] pci_ecam_create+0x130/0x1ec > [ 2.625209] [] pci_acpi_scan_root+0x160/0x218 > [ 2.631096] [] acpi_pci_root_add+0x36c/0x42c > [ 2.636897] [] acpi_bus_attach+0xe4/0x1a8 > [ 2.642438] [] acpi_bus_attach+0x150/0x1a8 > [ 2.648066] [] acpi_bus_attach+0x150/0x1a8 > [ 2.653693] [] acpi_bus_scan+0x64/0x74 > [ 2.658975] [] acpi_scan_init+0x5c/0x19c > [ 2.664429] [] acpi_init+0x280/0x2a4 > [ 2.669538] [] do_one_initcall+0x8c/0x19c > [ 2.675080] [] kernel_init_freeable+0x14c/0x1ec > [ 2.681139] [] kernel_init+0x10/0xfc > [ 2.686248] [] ret_from_fork+0x10/0x40 > > In hisi_pcie_init, I used "struct acpi_device *device = > ACPI_COMPANION(dev);". > I found the reason is V7 lack the below code. I added the below code, it > worked ok. > > [PATCH V6 01/13] pci, acpi, x86, ia64: Move ACPI host bridge device > companion assignment to core code. > --- a/drivers/acpi/pci_root.c > +++ b/drivers/acpi/pci_root.c > @@ -564,6 +564,11 @@ static int acpi_pci_root_add(struct acpi_device > *device, > } > } > > + /* > + * pci_create_root_bus() needs to detect the parent device type, > + * so initialize its companion data accordingly. > + */ > + ACPI_COMPANION_SET(&device->dev, device); > > This code will be upstreamed with the "PATCH V6 11/13 specic quirks" in > next time after the patchset is accepted. > Right ? We had that patch in previous series to retrieve PCI domain nicely. But that has bad implication to userspace. See: https://lkml.org/lkml/2016/5/9/918 I understand that: [PATCH V6 01/13] pci, acpi, x86, ia64: Move ACPI host bridge device companion assignment to core code. helps to get firmware specific info in hisi_pcie_init but we need to figure out something better for quirk handling too. Tomasz