From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751492AbcEQUVV (ORCPT ); Tue, 17 May 2016 16:21:21 -0400 Received: from mail-bl2on0067.outbound.protection.outlook.com ([65.55.169.67]:6896 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750790AbcEQUVU (ORCPT ); Tue, 17 May 2016 16:21:20 -0400 Authentication-Results: gmx.de; dkim=none (message not signed) header.d=none;gmx.de; dmarc=none action=none header.from=caviumnetworks.com; Message-ID: <573B7D39.9050305@caviumnetworks.com> Date: Tue, 17 May 2016 13:21:13 -0700 From: David Daney User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Heinrich Schuchardt CC: Sunil Goutham , Robert Richter , , , Subject: Re: [PATCH 1/1] net: thunderx: avoid null pointer dereference References: <1463514038-9008-1-git-send-email-xypron.glpk@gmx.de> In-Reply-To: <1463514038-9008-1-git-send-email-xypron.glpk@gmx.de> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [50.233.148.158] X-ClientProxiedBy: SN2PR07CA010.namprd07.prod.outlook.com (10.255.174.27) To BN4PR07MB2129.namprd07.prod.outlook.com (10.164.63.11) X-MS-Office365-Filtering-Correlation-Id: eb5a6720-3293-41cc-6435-08d37e90cd1e X-Microsoft-Exchange-Diagnostics: 1;BN4PR07MB2129;2:6oSGWD4nETcunbCSWfeo7QnYO24BkICZm0MH4BzicT6KPcuk3WizgmX4Nt184OpBsu+oP5Vr4gTt5yi5hLcaNd+zlzxe8Buvt0XkXfXM5NIEunnLtRv9HEy5Einzj1oL3cfwRnr7ZYKPq7cCCDtlHHSa5IsQ8hy6VgtcvN4XR3jMmonYdkCFEUVYcKcgnv9g;3:NdbgRcrELmil2XGJoVya7XjuR/M2GlTZ9/QY6AFI3tvWdjhSKH5OUhO8k+zOmbW7fbgSiM2psuA1SQiueHwFiUcDVuTlsWNmpGP298Y9tffxnzRjrN12BiokQCt15FSm;25:gL1NK5BXAtWTL5tkJuK15gnT9umLDfq45847Q0+D0DB9X8YDXBbBH46GiIgVITQzs1NDhwgTOzJ70r8OkeRVXJN+hf7hiXXcpG+0E2pZOI/CVKqU7UoPrPN/gkzl0YDt+7gAxcbqn2IqlnVcLhhD3OrD/h2k17HYWEyHdGVwDiJAVuFSKNrzx1DTOsN0NN/JjgoFyId0MIxUzKUTw5owbYFphPxyxSUvR/WPqZYBo75IgkdxEkIgQZKOwNuh7TO9a6RqO7GUPOtMKsVv8aFxXU+BMlQfKz4L5IDtNT56jCzIZYUT/iXH+D6Uyy/ok6FctgqVHHsdb3jwm50mbQshsajAJAhZU9yDztb64qyRlq5N94nJtjCmV0EwC9ks8MyDacnEEemFRdvJZTHBBvSmP/0P7cIvCBZrxrQqIrXi0KM= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN4PR07MB2129; X-Microsoft-Exchange-Diagnostics: 1;BN4PR07MB2129;20:GxQ0D0145FIkm5J6UkPpiUGxjlQkw+nE5UV+R9A6j6UFsWG2Pr7FbW5Y7z0YQIe+MUrOcBqPfte3O4rWkSDPqIQ3h3AWFwsNY/Pi8c87UAvVjM0fK7WgMejxHKUdQM4OfnOzG/rCNl2DcJTPdnwCW/XqsyafS2FY/g2i7DzDc+LjPgt0ZOJuFk5ugO0qXTMyhv3Fb7E5cVP3MweesKNm3/YXQAtidSL0S2+fOqeVzMWbk2zyiwXqVk8Gs9axZ728x5NHSJBwRR76G+7/jsXOpL5MXGjpgrz2Pn8eKHHFZITN+2GS4clvgpNTEcb9byjplhL0nGd5Yhz2z+wVfMQSCDdJUmZ+cKED+7U655TOmO9lAatKJ6Wbbfx3MdqB+q4SeIdtM8QtZLoqjCigPJSIDxBI7LnoDBNzIVxL6kSLVIlYFOuouq7NyizmnfvTtodMQl4KfsiIrTrmyAtR/BSiUaRc0KNtHVhw7DZjAdV81DsiF+b60bfYHS6+CX5SLsPQL+NujAXhPALpPMQwz04JgnC6d8k/dI/MugUtVnYNHOiRqEb4ZH6n2aPRN3Dg3b6a956EtcH2wRqGZ4VfZEjDrcZWR4KqmDxTicctPt8AyxQ= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046);SRVR:BN4PR07MB2129;BCL:0;PCL:0;RULEID:;SRVR:BN4PR07MB2129; X-Microsoft-Exchange-Diagnostics: 1;BN4PR07MB2129;4:j1Q3vrUEGuMNnYNfOGoiRoZkwG/j58kPhdh4F2iUjlHW48ZcD4cDdToB2T2+4aJYDqEZdtOatZJSKj8+z2flc1XmauFYsa1V+ilo2IHj++rlmMHSIKcZbW2IerbVfKszV850tKanSLyrgFP1vRdhDh31WFEbLPBOshefYVrlkSFZXvnzd3VfEsrPIT2DY5Fmp2GYMaAWyWanuKB6P1UXfQXTP/enKIq0CqLjwXF4iYk8WpOZ1XbsxLBb8IOMZN4Rmd67WP5fCIQlMrQAcS4p3O4OPHt4XtusXBpxMxCCfyxsi6Qq88MHwXAVEIlyoAbK46HHeiq2u+LAr/iu2JseZqhRPp93QcZOtk+Gv2uTZ1ABnC2tzCo93nyyNqAjrAVn X-Forefront-PRVS: 0945B0CC72 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(377454003)(24454002)(4001350100001)(189998001)(2906002)(5008740100001)(4326007)(110136002)(230700001)(2950100001)(76176999)(87266999)(54356999)(50986999)(6116002)(3846002)(586003)(80316001)(19580395003)(19580405001)(77096005)(83506001)(8676002)(33656002)(65956001)(81166006)(36756003)(53416004)(64126003)(47776003)(5004730100002)(65806001)(50466002)(92566002)(23756003)(42186005)(7059030);DIR:OUT;SFP:1101;SCL:1;SRVR:BN4PR07MB2129;H:dl.caveonetworks.com;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?iso-8859-1?Q?1;BN4PR07MB2129;23:rnaBUwSCGWE2DH9gf0Gok4XlorrBiaWgmvjG9tK?= =?iso-8859-1?Q?s/CTcNzea47SWwFG+MSoBWiAxGAJsvEuQjXEAOAGQKbxarwKVJxDy/UvoB?= =?iso-8859-1?Q?59La3osofSLrmTn96D0PREYYAiKwb4jzgnCee7dZAbnnjH7nATG7bTliw5?= =?iso-8859-1?Q?WgBm7IxThGS9KIg84tUbLSwzDPnSrhzYJBP+Findj2ehrQ84WzwyCt/1/f?= =?iso-8859-1?Q?XG+BfQXUQd1tKOF0TjUyfienU4qqtTQZQMQn3S1tESqkBa2FlYyhWxDqpF?= =?iso-8859-1?Q?uCoGWotaJJ8eap2M8Ib6SBsEkOd/XZB2Di6n8xytzz5y6kNrCD5hQwyvFz?= =?iso-8859-1?Q?GjWwu/4kuWP4eFnvFIlapIFI7Uyn6fZnoG8xi9OWdhkqWjw/O7RTVnboef?= =?iso-8859-1?Q?ovonSTxla+UPo1Qy9jSPVsR+v30fnhGZu+VNZXnV3Vm5gfvQ3pNSq+sQAR?= =?iso-8859-1?Q?2YObXj/834zuKXWq69l5ocjmRzBr/SFHSW4XLf+K0vsplB8MhW/2CtuLl4?= =?iso-8859-1?Q?/Xeu8HRIU8gGH3hbWAdtXEa1s8yxq0gG6GfpqeM621vT4lGAHzs12VIUmn?= =?iso-8859-1?Q?DOd/Mkf/00Oro0oBnodKKZT+OhpcsGPv7LTAQ/rcdjGw+/5GGtMqkzwqw1?= =?iso-8859-1?Q?7zCIrdRdDafjNDD//0mUEL5tyViMZ9tE4scQOdcydXuylFu9BC23peXl+L?= =?iso-8859-1?Q?MDZzGkg3T2mZO/NvXhsyTtMBJqDz91rM2an2XCnVLD+a7tA6d/5NyXSnSw?= =?iso-8859-1?Q?TSeB57lrQSnu6Usvt7e4gOUGRJNZfck5Ac4SRvM7IjA43RsPU7Jf+hNOKi?= =?iso-8859-1?Q?+g2uhZT7Le0nhITiE/gPpANFMqWI8ObwliSg5+GyPtADj7vWtY+Sj48RZH?= =?iso-8859-1?Q?XobRR+B1fJandGq6jIskY5PR+aUVs7rBhThsOs60OSsB2xupol+DybF0Av?= =?iso-8859-1?Q?8hhdfWj4riGDFAqbTxK8hgUwOPn8PJ2Wkdnx7E+HmoosCAwwGF7+qd1mUv?= =?iso-8859-1?Q?2dlNTE1hamvinKIxx8b4AOMdx7QI05qcyqq2b2pNlG5ZvcZXgNFMtOy3tv?= =?iso-8859-1?Q?SPlqPDoD2ZF42JC4dK5RQ=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN4PR07MB2129;5:cS8exyQka++RwoLADOCRSvG5fSh2sNKyKLtoVj0XIugbT30lNvQN+GZtHT2U6J9wSRbr5x0P1yCZp57gGgGEzpLjVVuTuyhS7zVnvuSrStAuiZ8rLwHsWHiq1lcSsKm1YnRUlNl5L0elLNL602I/ug==;24:DUQJWfCyQSZguYNHj71/LQ7H7RBnbs3RJSpi8FrBGesD8NijnHcK0VUDHqM0KbTCxiO1ZK5i89W9AdSwRSxjx8Whtxq+nILUrdD92JNeRN0=;7:v1dI8Oo/3AtDMwCdEcRGhISUFPR+dkQfK4vGOPtD8JhcBMxaMthmCmfDikxJ/HfVoiHlEXEdhHlzzse2Q9kqh/mK7b7HuEaIXL9gjp0GcZuz4eQSne+a9cHgyKFog8sERoI0+xU2LTursB7zA/QW7maLVjO5jLogTBHQTSgJ42TV0I7XY5+OGltRd5/4Zd1O SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2016 20:21:16.4520 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN4PR07MB2129 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/17/2016 12:40 PM, Heinrich Schuchardt wrote: > In function bgx_lmac_handler only use a member of > lmac after checking it is not null. > Were you seeing and actual OOPs, or is this only a theoretical problem flagged by some sort of static code checker? > Signed-off-by: Heinrich Schuchardt In any event, it seems sane to make this change, so: Acked-by: David Daney > --- > drivers/net/ethernet/cavium/thunder/thunder_bgx.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c > index d20539a..3ed2198 100644 > --- a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c > +++ b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c > @@ -274,12 +274,14 @@ static void bgx_sgmii_change_link_state(struct lmac *lmac) > static void bgx_lmac_handler(struct net_device *netdev) > { > struct lmac *lmac = container_of(netdev, struct lmac, netdev); > - struct phy_device *phydev = lmac->phydev; > + struct phy_device *phydev; > int link_changed = 0; > > if (!lmac) > return; > > + phydev = lmac->phydev; > + > if (!phydev->link && lmac->last_link) > link_changed = -1; > >