From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752798AbcERCAU (ORCPT ); Tue, 17 May 2016 22:00:20 -0400 Received: from mr213139.mail.yeah.net ([223.252.213.139]:52023 "EHLO mr213139.mail.yeah.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752366AbcERCAR (ORCPT ); Tue, 17 May 2016 22:00:17 -0400 Subject: Re: [PATCH] mmc: dw_mmc: Consider HLE errors to be data and command errors To: Doug Anderson , Jaehoon Chung References: <1426002490-2014-1-git-send-email-dianders@chromium.org> <5502CA4E.9060401@samsung.com> <5506707D.40708@samsung.com> <55189F04.8000404@samsung.com> Cc: Seungwon Jeon , Ulf Hansson , Alim Akhtar , Sonny Rao , Heiko Stuebner , Alexandru Stan , Javier Martinez Canillas , "open list:ARM/Rockchip SoC..." , "linux-arm-kernel@lists.infradead.org" , "linux-mmc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Shawn Lin From: Shawn Lin Message-ID: <573BCC8D.5090606@kernel-upstream.org> Date: Wed, 18 May 2016 09:59:41 +0800 User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-HM-Spam-Status: e1koWUFPN1dZCBgUCR5ZQVZLVUpDSUJCQkNPQkhKQk9OQ1dZCQ4XHghZQV koKz0kNT4uLyk6NyQyNSQzPjo*PilBS1VLQDYjJCI#KCQyNSQzPjo*PilBS1VLQCsvKSQiPigkMj UkMz46Pz4pQUtVS0A4NC41LykiJDg1QUtVS0ApPjwyNDUkOigyOkFLVUtAKyk0LTI1OD4kPS4xMj o1QUtVS0A*IjU6NjI4JDIrJDU0JDI1JDM#Oj8#KUFLVUtANi43LzIkKTgrLyQ*Mj09Pik#NS8kMj UkMz46Pz4pQUlVS0AyKyROJDYyNS4vPiQ4NS8kSyRKS0FLVUtAMiskSiQ2MjUuLz4kODUvJEskSk tBS1VLQDIrJC80PzoiJDg1LyRLJEpLS0FLVUtAMiskSiQzNC4pJDg1LyRLJEpLS0FLVUtAMiskSE skNjI1Li8#JDg1LyRLJE5LQUtVS0AoLjkxPjgvJE4kNjI1Li8#JDg1LyRLJEpLQUtVS0AoLjkxPj gvJC80PzoiJDg1LyRLJEpLS0FLVUtAKC45MT44LyRKJDM0LikkODUvJEskSktLQUtVS0AoOTEkNz 41JE9LJCNBS1VLS0pLQC8#Iy8kNz41JEpJQ0skI0FLVUtLSktAODUvJDMvNjckNz41JEowJE4wQU tVS0tKS0ApPjg#Mi0#KSQ4NS8kTiQjQUtVS0tKS0AjNjoyNz4pJDUuNzdBS1VLS0pLQD8#NzItPi kkNz41JEtBS1VLS0pLQDc6NTwkPjVBS1VLS0pLQD01JDY6IiRPSkIkMzcxJEokS0NLSEtPQUtVSE hAPSskKT4kPSwkMzcxJEtDS0hLTUFWTFVOQD01JCguOSQ#NSw0KT8oJDM3MSRKS0tJS0pBS1VJQ0 AoLjkkPkFKVU5OQD01JDkyL0wkMzcxJEtMSklLSUFIVUpOQD01JDY6IiRPSkIkMzcxJEkkS0NLSE tPQUtVS1kG X-HM-Sender-Digest: e1kSHx4VD1lBWUc6NE06DTo5Sjo0DU0rIis9ASMvOkwaCwhVSlVKT01I TkhNQ0pJSENKVTMWGhIXVQgTGgwVVRcSFTsQHgkVHhdWDgsIDwkeGhZVFAkcRVlXWQweGVlBHRoX CB5XWQgBWUFOS0hIN1dZEgtZQVlOQ1VJSVVMVUpKT1kG X-HM-Tid: 0a54c19780b87d8bd9d991c17de Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Doug, On 2016-5-18 8:47, Doug Anderson wrote: > Jaehoon, > > On Mon, Mar 30, 2015 at 8:47 AM, Doug Anderson wrote: >> Jaehoon, >> >> On Sun, Mar 29, 2015 at 5:55 PM, Jaehoon Chung wrote: >>> Dear Doug, >>> >>> I'm considering to control HLE error..So holding this patch. >>> If this is absolutely necessary patch, let me know, plz. >>> >>> Best Regards, >>> Jaehoon Chung >> Sounds OK. I have certainly applied this locally and the driver isn't >> robust against insertions / removals without it, but once the card is >> inserted things are OK so it's probably not urgent that it be applied >> upstream. Hopefully we can figure out a better solution... > I'm now testing a nice new rebased kernel and I'm hitting this again. > > Of course I'll just pick my same patch to my new kernel tree, but > since it's been a year and nobody has done anything better, would you > consider landing my patch? It is certainly better than nothing. Could you try this patch to see if you can still find HLE? @@ -2356,12 +2356,22 @@ static void dw_mci_cmd_interrupt(struct dw_mci *host, u32 status) static void dw_mci_handle_cd(struct dw_mci *host) { int i; + int present; for (i = 0; i < host->num_slots; i++) { struct dw_mci_slot *slot = host->slot[i]; if (!slot) continue; + present = !(mci_readl(slot->host, CDETECT) & (1 << slot->id)); + if (present) + set_bit(DW_MMC_CARD_PRESENT, &slot->flags); + else + clear_bit(DW_MMC_CARD_PRESENT, &slot->flags); if (slot->mmc->ops->card_event) slot->mmc->ops->card_event(slot->mmc); > > -Doug > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >