From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752664AbcERCI7 (ORCPT ); Tue, 17 May 2016 22:08:59 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:52953 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752488AbcERCI5 (ORCPT ); Tue, 17 May 2016 22:08:57 -0400 X-AuditID: cbfee691-f79196d000001483-46-573bceb52779 Message-id: <573BCEB5.8020905@samsung.com> Date: Wed, 18 May 2016 11:08:53 +0900 From: Jaehoon Chung User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-version: 1.0 To: Doug Anderson Cc: Ulf Hansson , Alim Akhtar , Sonny Rao , Heiko Stuebner , Alexandru Stan , Javier Martinez Canillas , "open list:ARM/Rockchip SoC..." , "linux-arm-kernel@lists.infradead.org" , Chris Ball , "linux-mmc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Shawn Lin Subject: Re: [PATCH] mmc: dw_mmc: Consider HLE errors to be data and command errors References: <1426002490-2014-1-git-send-email-dianders@chromium.org> <5502CA4E.9060401@samsung.com> <5506707D.40708@samsung.com> <55189F04.8000404@samsung.com> In-reply-to: Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrIIsWRmVeSWpSXmKPExsWyRsSkRHfrOetwgyfHLCwezNvGZtHwYhKr xYTL2xktzi47yGbx/9FrVoujvwssNj2+xmpxedccNosj//sZLT49+M9scefJelaLJ2dmMloc XxvuwOsxu+Eii8ff59dZPO5c28PmsXlJvceNVwuZPP7O2s/i0bdlFaPH9mvzmD0+b5IL4Izi sklJzcksSy3St0vgynj78ARbwV+eimtT9rI1MK7k6mLk5JAQMJF4/WwPG4QtJnHh3nogm4tD SGAFo8Suz0uZuhg5wIpmnI2CiC9llGh6sJ0JwnnAKPHrwhVmkG5eAS2Jmd8XMIHYLAKqEm8v bWEBsdkEdCS2fzsOFhcVCJN4sG4vK0S9oMSPyffAakQENCWeNbxkBhnKLHCLReLat5NgJwkL hEq0/OiAOukHk8SpWccZQU7iFAiWeH8jEcRkFlCXmDIlF6ScWUBeYvOat2BzJATmckj8mXyH EeIgAYlvkw+xQHwjK7HpADPEx5ISB1fcYJnAKDYLyUmzEKbOQjJ1ASPzKkbR1ILkguKk9CJT veLE3OLSvHS95PzcTYzAmD7979nEHYz3D1gfYhTgYFTi4Y3otQ4XYk0sK67MPcRoCnTERGYp 0eR8YOLIK4k3NDYzsjA1MTU2Mrc0UxLn1ZH+GSwkkJ5YkpqdmlqQWhRfVJqTWnyIkYmDU6qB 8fAj6VuOLqIVr5yE1F5MObm2bZP4H7ezU0LaGx6d7rjNE3BEzmgnx9W0Wd5ap7MUnjavvn5V fEdix+v305SU/uV9bY48/GHvv9fMfLPUeCym+5xc/Olfdfr2q6+7pJ+/fCrXvv7h3XUv9rjt 7Ob8O7kxOP71y8Oqzjt3Bgduurf/6vxnU04+vXdciaU4I9FQi7moOBEATH8qZuQCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprHKsWRmVeSWpSXmKPExsVy+t9jAd2t56zDDQ7vM7B4MG8bm0XDi0ms FhMub2e0OLvsIJvF/0evWS2O/i6w2PT4GqvF5V1z2CyO/O9ntPj04D+zxZ0n61ktnpyZyWhx fG24A6/H7IaLLB5/n19n8bhzbQ+bx+Yl9R43Xi1k8vg7az+LR9+WVYwe26/NY/b4vEkugDOq gdEmIzUxJbVIITUvOT8lMy/dVsk7ON453tTMwFDX0NLCXEkhLzE31VbJxSdA1y0zB+hsJYWy xJxSoFBAYnGxkr4dpgmhIW66FjCNEbq+IUFwPUYGaCBhDWPG24cn2Ar+8lRcm7KXrYFxJVcX IweHhICJxIyzUV2MnECmmMSFe+vZuhi5OIQEljJKND3YzgThPGCU+HXhCjNIFa+AlsTM7wuY QGwWAVWJt5e2sIDYbAI6Etu/HQeLiwqESTxYt5cVol5Q4sfke2A1IgKaEs8aXjKDDGUWuMUi ce3bSTaQhLBAqETLjw6o1T+YJE7NOs4Ich6nQLDE+xuJICazgLrElCm5IOXMAvISm9e8ZZ7A KDALyYpZCFWzkFQtYGRexSiRWpBcUJyUnmuYl1quV5yYW1yal66XnJ+7iRGcNp5J7WA8uMv9 EKMAB6MSD++GfutwIdbEsuLK3EOMEhzMSiK8+WeBQrwpiZVVqUX58UWlOanFhxhNgWEwkVlK NDkfmNLySuINjU3MjCyNzA0tjIzNlcR5H/9fFyYkkJ5YkpqdmlqQWgTTx8TBKdXAyM4gteXg ovUvez+wPk4Vlv7k+Pq496+qCb9WPEvZH/Osft3CnyFV56LcMo7lmppGJb5Ky/qv/IjFof92 0IktH29sU3eTktlovFqdvWTaW45z177euRlYAUyOOecCDnBZ73nNdlp43YzFmQdmWN+/e5r3 3tNPX9/Mr9y7t7Zeo+6jrI265qmALUosxRmJhlrMRcWJAI+E+TsxAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/18/2016 09:47 AM, Doug Anderson wrote: > Jaehoon, > > On Mon, Mar 30, 2015 at 8:47 AM, Doug Anderson wrote: >> Jaehoon, >> >> On Sun, Mar 29, 2015 at 5:55 PM, Jaehoon Chung wrote: >>> Dear Doug, >>> >>> I'm considering to control HLE error..So holding this patch. >>> If this is absolutely necessary patch, let me know, plz. >>> >>> Best Regards, >>> Jaehoon Chung >> >> Sounds OK. I have certainly applied this locally and the driver isn't >> robust against insertions / removals without it, but once the card is >> inserted things are OK so it's probably not urgent that it be applied >> upstream. Hopefully we can figure out a better solution... > > I'm now testing a nice new rebased kernel and I'm hitting this again. > > Of course I'll just pick my same patch to my new kernel tree, but > since it's been a year and nobody has done anything better, would you > consider landing my patch? It is certainly better than nothing. Sure, it's right. I think that main reason of HLE is wait_prvdata_complete. (I'm guessing..) On other hands, dwmmc controller is handling something wrong. (I found that HLE is occurred the similar case.) After find the main solution, it's not bad that your patch is applied on dwmmc controller. Ulf have sent PR for next..So if we needs to apply this, i will apply on fix. Best Regards, Jaehoon Chung > > -Doug > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > >