public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Juergen Gross <jgross@suse.com>,
	xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Cc: sstabellini@kernel.org, david.vrabel@citrix.com
Subject: Re: [PATCH] xen: add steal_clock support on x86
Date: Wed, 18 May 2016 10:46:39 -0400	[thread overview]
Message-ID: <573C804F.6020708@oracle.com> (raw)
In-Reply-To: <1463573758-11441-1-git-send-email-jgross@suse.com>

On 05/18/2016 08:15 AM, Juergen Gross wrote:
>  }
>  
> +void __init xen_time_setup_guest(void)
> +{
> +	pv_time_ops.steal_clock = xen_steal_clock;
> +
> +	static_key_slow_inc(&paravirt_steal_enabled);
> +	/*
> +	 * We can't set paravirt_steal_rq_enabled as this would require the
> +	 * capability to read another cpu's runstate info.
> +	 */
> +}

Won't we be accounting for stolen cycles twice now --- once from
steal_account_process_tick()->steal_clock() and second time from
do_stolen_accounting()?

-boris

  reply	other threads:[~2016-05-18 14:47 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-18 12:15 [PATCH] xen: add steal_clock support on x86 Juergen Gross
2016-05-18 14:46 ` Boris Ostrovsky [this message]
2016-05-18 14:53   ` Juergen Gross
2016-05-18 15:25     ` Boris Ostrovsky
2016-05-18 15:42       ` Juergen Gross
2016-05-18 15:45         ` David Vrabel
2016-05-18 15:51           ` Juergen Gross
2016-05-18 15:52             ` David Vrabel
2016-05-18 15:53           ` Boris Ostrovsky
2016-05-18 16:00             ` Juergen Gross
2016-05-18 16:13               ` Boris Ostrovsky
2016-05-19  5:33                 ` Juergen Gross
2016-05-18 16:10     ` [Xen-devel] " Dario Faggioli
2016-05-18 17:20       ` Boris Ostrovsky
2016-05-18 17:59         ` Tony S
2016-05-18 18:03           ` Tony S
2016-05-19  3:36             ` Dario Faggioli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=573C804F.6020708@oracle.com \
    --to=boris.ostrovsky@oracle.com \
    --cc=david.vrabel@citrix.com \
    --cc=jgross@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox