From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932612AbcERPCD (ORCPT ); Wed, 18 May 2016 11:02:03 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:64739 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753155AbcERPBz (ORCPT ); Wed, 18 May 2016 11:01:55 -0400 X-AuditID: cbfec7f4-f796c6d000001486-77-573c83dfcd61 Subject: Re: [PATCH] ARM: exynos: don't select keyboard driver To: Arnd Bergmann , Kukjin Kim References: <1463581102-1007639-1-git-send-email-arnd@arndb.de> Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org From: Krzysztof Kozlowski X-Enigmail-Draft-Status: N1110 Message-id: <573C83DE.60106@samsung.com> Date: Wed, 18 May 2016 17:01:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-version: 1.0 In-reply-to: <1463581102-1007639-1-git-send-email-arnd@arndb.de> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrDLMWRmVeSWpSXmKPExsVy+t/xy7r3m23CDdoPyVj8nXSM3eL1C0OL /sevmS02Pb7GanF51xw2ixnn9zE5sHn8/jWJ0WPTqk42j81L6j36tqxi9Pi8SS6ANYrLJiU1 J7MstUjfLoEr4/LuRewFc3kr5qyXa2BcwN3FyMkhIWAi8e/qBTYIW0ziwr31QDYXh5DAUkaJ rbc/MoMkhASeMUrceuUCYgsL2Encb5nJAmKLCDhIvN4yjQmixl7i3O3ZQDYHB7NAtsSWV2Bh NgFjic3Ll0DNl5Po7Z4E1soroCFxuacHrIZFQFXi2e5L7CC2qECExOp115ghagQlfky+B1bP CbTqXOsRdojxehL3L2qBhJkF5CU2r3nLPIFRcBaSjlkIVbOQVC1gZF7FKJpamlxQnJSea6hX nJhbXJqXrpecn7uJERLmX3YwLj5mdYhRgINRiYd3Q791uBBrYllxZe4hRgkOZiURXv9am3Ah 3pTEyqrUovz4otKc1OJDjNIcLErivHN3vQ8REkhPLEnNTk0tSC2CyTJxcEo1MJo+FNiz/cit iZ4yk09evPLTRtstkpvPa32+x5onbns4z0ZlybWYun2WPOhWHr/Yd5ec/AvlZ3mPXXT+nqid VeMx/cpOkVN1R6+9nl5R8NJkqrXBnjMKR85+UA/PCNud7CxvrfFVpPDId/OD50/EPl9/3FAr qPVyy6yg7TyeXMUm06Xb1ydv/aLEUpyRaKjFXFScCAAZme0EbwIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/18/2016 04:17 PM, Arnd Bergmann wrote: > The samsung-keypad driver is implicitly selected by ARCH_EXYNOS4 (why?), > but this fails if CONFIG_INPUT is a loadable module: > > drivers/input/built-in.o: In function `samsung_keypad_remove': > drivers/input/keyboard/samsung-keypad.c:461: undefined reference to `input_unregister_device' > drivers/input/built-in.o: In function `samsung_keypad_irq': > drivers/input/keyboard/samsung-keypad.c:137: undefined reference to `input_event' > drivers/input/built-in.o: In function `samsung_keypad_irq': > include/linux/input.h:389: undefined reference to `input_event' > drivers/input/built-in.o: In function `samsung_keypad_probe': > drivers/input/keyboard/samsung-keypad.c:358: undefined reference to `devm_input_allocate_device' > drivers/input/built-in.o:(.debug_addr+0x34): undefined reference to `input_set_capability' > > This removes the 'select' as suggested by Krzysztof Kozlowski and > instead enables the driver from the defconfig files. > > The problem does not happen on mainline kernels, as we don't normally > build built-in input drivers when CONFIG_INPUT=m, but I am experimenting > with a patch to change this, and the samsung keypad driver showed up > as one example that was silently broken before. > > Signed-off-by: Arnd Bergmann > Link: https://lkml.org/lkml/2016/2/14/55 > --- > arch/arm/configs/exynos_defconfig | 1 + > arch/arm/configs/multi_v7_defconfig | 1 + > arch/arm/mach-exynos/Kconfig | 1 - > 3 files changed, 2 insertions(+), 1 deletion(-) Thanks for update. Applied for v4.7 (same reason as in plat-samsung/devs.c). Best regards, Krzysztof