From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754338AbcESLEu (ORCPT ); Thu, 19 May 2016 07:04:50 -0400 Received: from foss.arm.com ([217.140.101.70]:34268 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753713AbcESLEt (ORCPT ); Thu, 19 May 2016 07:04:49 -0400 Subject: Re: [PATCH] arm64: cpuinfo: add AArch64 & elf platform for app compatibility To: x00195127 , catalin.marinas@arm.com, will.deacon@arm.com References: <1463625873-60016-1-git-send-email-saberlily.xia@hisilicon.com> Cc: puck.chen@hisilicon.com, suzhuangluan@hisilicon.com, linaro-kernel@lists.linaro.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org From: Robin Murphy Message-ID: <573D9DCD.8020308@arm.com> Date: Thu, 19 May 2016 12:04:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <1463625873-60016-1-git-send-email-saberlily.xia@hisilicon.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/05/16 03:44, x00195127 wrote: > we find that some apps will read cpuinfo when start up, > they need the string as follows: > "Processor : AArch64 Processor rev 0 (aarch64)" > > Then thay could load the corresponding libs. But now > arm64 platform's cpuinfo don't has this now, so > we need add this. > > Signed-off-by: Qing Xia > --- > arch/arm64/kernel/cpuinfo.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm64/kernel/cpuinfo.c b/arch/arm64/kernel/cpuinfo.c > index 3808470..c3527ad 100644 > --- a/arch/arm64/kernel/cpuinfo.c > +++ b/arch/arm64/kernel/cpuinfo.c > @@ -114,6 +114,9 @@ static int c_show(struct seq_file *m, void *v) > * online processors, looking for lines beginning with > * "processor". Give glibc what it expects. > */ > + seq_printf(m, "Processor\t: AArch64 Processor rev %d (%s)\n", > + read_cpuid_id() & 15, ELF_PLATFORM); The pre-3.19 behaviour printed this once - now you're printing it for every CPU in the system, but all with the same revision of whichever core this happens to be running on, which is unjustifiably incorrect. Furthermore, this string provides virtually no useful information anyway - the majority of code running on AArch64 already knows that by virtue of the fact that *it's running at all*, and for scripts/interpreted code/etc. there are already appropriate mechanisms for discovering the platform (e.g. uname). Robin. > + > seq_printf(m, "processor\t: %d\n", i); > > seq_printf(m, "BogoMIPS\t: %lu.%02lu\n", >