From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755011AbcESNns (ORCPT ); Thu, 19 May 2016 09:43:48 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:16479 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754982AbcESNnr convert rfc822-to-8bit (ORCPT ); Thu, 19 May 2016 09:43:47 -0400 Subject: Re: [PATCH v3] xen: add steal_clock support on x86 To: Juergen Gross , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org References: <1463664367-7675-1-git-send-email-jgross@suse.com> Cc: sstabellini@kernel.org, david.vrabel@citrix.com From: Boris Ostrovsky Message-ID: <573DC2FA.3080008@oracle.com> Date: Thu, 19 May 2016 09:43:22 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <1463664367-7675-1-git-send-email-jgross@suse.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8BIT X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/19/2016 09:26 AM, Juergen Gross wrote: > The pv_time_ops structure contains a function pointer for the > "steal_clock" functionality used only by KVM and Xen on ARM. Xen on x86 > uses its own mechanism to account for the "stolen" time a thread wasn't > able to run due to hypervisor scheduling. > > Add support in Xen arch independent time handling for this feature by > moving it out of the arm arch into drivers/xen and remove the x86 Xen > hack. > > Signed-off-by: Juergen Gross Reviewed-by: Boris Ostrovsky I think this also needs to be acked by (or at least copied to) generic Linux maintainers. > --- > arch/arm/xen/enlighten.c | 17 ++--------------- > arch/x86/xen/time.c | 44 ++------------------------------------------ > drivers/xen/time.c | 20 ++++++++++++++++++++ > include/linux/kernel_stat.h | 1 - > include/xen/xen-ops.h | 1 + > kernel/sched/cputime.c | 10 ---------- > 6 files changed, 25 insertions(+), 68 deletions(-) ... > } > diff --git a/drivers/xen/time.c b/drivers/xen/time.c > index 7107842..2257b66 100644 > --- a/drivers/xen/time.c > +++ b/drivers/xen/time.c > @@ -6,6 +6,7 @@ > #include > #include > > +#include > #include > #include > > @@ -75,6 +76,15 @@ bool xen_vcpu_stolen(int vcpu) > return per_cpu(xen_runstate, vcpu).state == RUNSTATE_runnable; > } (Unrelated to this patch.) Should this include RUNSTATE_offline as well? -boris