From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933486AbcESSlX (ORCPT ); Thu, 19 May 2016 14:41:23 -0400 Received: from mga02.intel.com ([134.134.136.20]:20307 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933443AbcESSlU (ORCPT ); Thu, 19 May 2016 14:41:20 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,335,1459839600"; d="scan'208";a="980656826" Reply-To: sathyanarayanan.kuppuswamy@linux.intel.com Subject: Re: [PATCH] iio: light: jsa1212: remove unneeded i2c check functionality test References: <20160515183717.GA2674@d830.WORKGROUP> To: Alison Schofield , jic23@kernel.org Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, mranostay@gmail.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org From: sathyanarayanan kuppuswamy Organization: Intel Message-ID: <573E07EA.8050007@linux.intel.com> Date: Thu, 19 May 2016 11:37:30 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160515183717.GA2674@d830.WORKGROUP> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Looks Good. Reviewed-by:Kuppuswamy Sathyanarayanan On 05/15/2016 11:37 AM, Alison Schofield wrote: > This driver does not call i2c_smbus_read|write_byte_data(), > so remove the corresponding functionality test. It uses regmap > to handle byte transfers transparently. > > Signed-off-by: Alison Schofield > --- > Found & fixed by inspection based on same defect recently fixed > in light/tpl0102 driver. > > > drivers/iio/light/jsa1212.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/iio/light/jsa1212.c b/drivers/iio/light/jsa1212.c > index 99a6281..e8a8931 100644 > --- a/drivers/iio/light/jsa1212.c > +++ b/drivers/iio/light/jsa1212.c > @@ -325,9 +325,6 @@ static int jsa1212_probe(struct i2c_client *client, > struct regmap *regmap; > int ret; > > - if (!i2c_check_functionality(client->adapter, I2C_FUNC_SMBUS_BYTE_DATA)) > - return -EOPNOTSUPP; > - > indio_dev = devm_iio_device_alloc(&client->dev, sizeof(*data)); > if (!indio_dev) > return -ENOMEM; -- Sathyanarayanan Kuppuswamy Android kernel developer