From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933234AbcESUfy (ORCPT ); Thu, 19 May 2016 16:35:54 -0400 Received: from mail-pa0-f53.google.com ([209.85.220.53]:34753 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933159AbcESUfw (ORCPT ); Thu, 19 May 2016 16:35:52 -0400 Subject: Re: [PATCH v7 0/3] ASoC: cygnus: Add audio support for Broadcom Cygnus SoC To: Simran Rai , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Ray Jui , Scott Branden , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai References: <1463514382-20930-1-git-send-email-simran.rai@broadcom.com> Cc: Lori Hikichi , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org, Arun Parameswaran , alsa-devel@alsa-project.org, Simran From: Scott Branden Message-ID: <573E23A2.4020907@broadcom.com> Date: Thu, 19 May 2016 13:35:46 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1463514382-20930-1-git-send-email-simran.rai@broadcom.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Looks good Simran. Mark, anything else for us to do before this driver can be accepted upstream? On 16-05-17 12:46 PM, Simran Rai wrote: > From: Simran > > Hi, > > This patchset contains audio support for Broadcom's Cygnus SoC. > It contains DT bindings and core audio driver. The audio driver supports > both capture and playback of Audio PCM samples over I2S/TDM interface and > provides playback support over SPDIF interface. > > This patchset is derived from a previously submitted patchset: > http://lkml.iu.edu/hypermail/linux/kernel/1503.3/05434.html > > This patchset has been tested on Cygnus wireless audio bcm958305K board. > It is based on v4.6-rc1 and is available from github: > > repo: https://github.com/Broadcom/cygnus-linux/tree/cygnus-sound-v7 > > Changes from v6: > - DT bindings acknowledged by Rob Herring > Changes from v5: > - Fix code style, e.g. change "if" statements to "switch" statements > - Fix SPDIF output enable register field > - Set BUFFER_PAIR_ENABLE for both mono, stereo and TDM modes > - Reflect PCM bit formats for SPDIF, SSP and TDM as supported by > hardware > Changes from v4: > - Fix power suspend function and add power resume function > - Move clock initialization code from audio driver to clock framework > Changes from v3: > - Fix the subject lines to match the style for the subsystem > Changes from v2: > - Split patchset 2/2 from v2 into patchsets 2/3 and 3/3. > - Remove SND_SOC_CYGNUS_DIAG. Diagnostics can be performed using > standard kernel trace infrastructure. > - Fix interrupt handler. Acknowledge only those interrupts that are > handledby ISR. > - Modify configure_vco() and the pll_macro_entry() struct to make it > better readable. The functionality did not change. > - Remove casts on macros > - Remove surround sound channel grouping from the driver. > Changes from v1: > - Address code review comments. Fix print format of type size_t and > pointer. > > Simran Rai (3): > ASoC: cygnus: Add DT bindings for Broadcom Cygnus audio > ASoC: cygnus: Add Cygnus audio DAI driver > ASoC: cygnus: Add Cygnus audio DMA driver > > .../bindings/sound/brcm,cygnus-audio.txt | 67 + > sound/soc/bcm/Kconfig | 9 + > sound/soc/bcm/Makefile | 5 + > sound/soc/bcm/cygnus-pcm.c | 861 +++++++++++ > sound/soc/bcm/cygnus-ssp.c | 1529 ++++++++++++++++++++ > sound/soc/bcm/cygnus-ssp.h | 139 ++ > 6 files changed, 2610 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/brcm,cygnus-audio.txt > create mode 100644 sound/soc/bcm/cygnus-pcm.c > create mode 100644 sound/soc/bcm/cygnus-ssp.c > create mode 100644 sound/soc/bcm/cygnus-ssp.h >