From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755408AbcETBWI (ORCPT <rfc822;w@1wt.eu>);
	Thu, 19 May 2016 21:22:08 -0400
Received: from ozlabs.org ([103.22.144.67]:43827 "EHLO ozlabs.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754103AbcETBWF (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 19 May 2016 21:22:05 -0400
Subject: Re: [PATCH] fbcon: warn on invalid cursor blink intervals
To: Scot Doyle <lkml14@scotdoyle.com>, Tomi Valkeinen <tomi.valkeinen@ti.com>,
        Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
References: <1463510464-28124-1-git-send-email-ddaney.cavm@gmail.com>
 <20160517204912.GA29719@amd>
 <CACVXFVPdjfFkRFucTQsOHsVFtgm1W0JtOTqjyDzyNbzygghUyg@mail.gmail.com>
 <alpine.DEB.2.10.1605181519540.8967@laptop>
 <ed8fa4ca-49e0-3ff4-5499-fc5250dd8ae2@caviumnetworks.com>
 <alpine.DEB.2.10.1605182252230.12118@laptop>
 <573DE2D0.1050402@caviumnetworks.com>
 <alpine.DEB.2.10.1605191708400.15396@laptop>
 <alpine.DEB.2.10.1605191726030.15478@laptop>
Cc: David Daney <david.daney@cavium.com>, Ming Lei <ming.lei@canonical.com>,
        Dann Frazier <dann.frazier@canonical.com>,
        Peter Hurley <peter@hurleysoftware.com>, Pavel Machek <pavel@ucw.cz>,
        Jonathan Liu <net147@gmail.com>,
        Alistair Popple <alistair@popple.id.au>,
        Jean-Philippe Brucker <jean-philippe.brucker@arm.com>,
        "Chintakuntla, Radha" <Radha.Chintakuntla@caviumnetworks.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Slaby <jslaby@suse.com>, David Airlie <airlied@linux.ie>,
        ddaney.cavm@gmail.com, dri-devel@lists.freedesktop.org,
        linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        stable@vger.kernel.org
From: Jeremy Kerr <jk@ozlabs.org>
Message-ID: <573E66B6.40109@ozlabs.org>
Date: Fri, 20 May 2016 09:21:58 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.2
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.10.1605191726030.15478@laptop>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Scot,

> Two systems are locking on boot [1] because ops->cur_blink_jiffies
> is set to zero from vc->vc_cur_blink_ms.
> 
> Ignore such invalid intervals and log a warning.

This prevents a lockup on AST BMC machines, but (as expected) generates
a warning against the fbcon driver, which is a significantly better
result.

Tested-by: Jeremy Kerr <jk@ozlabs.org>

[now to sort out the issue in the ast driver...]

Cheers,


Jeremy