From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754873AbcETJzH (ORCPT ); Fri, 20 May 2016 05:55:07 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:59836 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752930AbcETJzE (ORCPT ); Fri, 20 May 2016 05:55:04 -0400 X-AuditID: cbfec7f4-f796c6d000001486-bd-573edef40823 Subject: Re: [PATCH] ARM: dts: exynos: Remove unneded always-on for regulators on Peach boards To: Javier Martinez Canillas , linux-kernel@vger.kernel.org References: <1463694753-7259-1-git-send-email-javier@osg.samsung.com> Cc: devicetree@vger.kernel.org, Kukjin Kim , Kumar Gala , Ian Campbell , linux-samsung-soc@vger.kernel.org, Rob Herring , Mark Rutland , Russell King , linux-arm-kernel@lists.infradead.org From: Krzysztof Kozlowski Message-id: <573EDEF2.8020903@samsung.com> Date: Fri, 20 May 2016 11:54:58 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-version: 1.0 In-reply-to: <1463694753-7259-1-git-send-email-javier@osg.samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpmkeLIzCtJLcpLzFFi42I5/e/4Vd0v9+zCDZ7tEbaYf+Qcq0X/m4Ws FuderWS0ePN2DZPF6xeGFv2PXzNbbHp8jdXi8q45bBYzzu9jsjg0dS+jxdLrF5ksWvceYXfg 8Vgzbw2jx+VrF5k9Lvf1MnmsXP6FzWPTqk42j81L6j229N9l9+jbsorR4/MmuQDOKC6blNSc zLLUIn27BK6MY11dzAWLeCvO3NnN1MB4gauLkZNDQsBEYsHpdnYIW0ziwr31bF2MXBxCAksZ JZ5t/cIC4TxjlLi+dSNrFyM7h7BAgsSHRJB6EYFQiX8XbzN2MXIAlbhKTLsVD1LNLHCOSWLl /JOsIDVsAsYSm5cvYQOxeQW0JD6fmg62i0VAVeLburVgNaICERKztv9ggqgRlPgx+R4LiM0p 4Cbxd98PVpD5zAJ6EvcvaoGEmQXkJTavecs8gVFgFpKOWQhVs5BULWBkXsUomlqaXFCclJ5r qFecmFtcmpeul5yfu4kREjVfdjAuPmZ1iFGAg1GJh/eAg124EGtiWXFl7iFGCQ5mJRHei3eB QrwpiZVVqUX58UWlOanFhxilOViUxHnn7nofIiSQnliSmp2aWpBaBJNl4uCUamA06Frxf0KG 7Pfq5KlO4i/4ltouT2C0qXr456RjXqnBg7teN1cm7GR7YSq/TCNqs8v9p9d+PZNovnd5TvaZ r/KPdlQGPgue3N0sFFvr9GPz66c66ose7W+yeHSe9fzfqX6pZUfl7hpP3jSv5lrLdHXTu/PO hbwwnmtc8Y9x+kabyD2athPsD/zUV2Ipzkg01GIuKk4EAFO4VL2WAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/19/2016 11:52 PM, Javier Martinez Canillas wrote: > The regulator always-on property should only be used for regulators > that either can't be disabled or the drivers for the client devices > are not enabling the regulator and so being disabled due to unused. > > There are some max77802 regulators in the Peach Pit and Pi boards > that are always-on but shouldn't since they are enabled by drivers: > > BUCK5 is max77802 inl1 supply > BUCK7 is max77802 inl{2,10} supply > BUCK9 is max77802 inl{3,4,5,7} supply > BUCK10 is mmc1 vqmmc supply > LDO9 is adc vdd supply > > This patch removes the always-on property for these regulators. > > Some regulators should remain always-on even when they are used as > input supplies, because these regulators are also used by other > components that are not described in the DT, for example: > > LDO10 is hdmi vdd_osc supply but it's also used as input supply for > the Exynos5420 temperature sensor. I don't have the schematics, so just guessing: by temperature sensor do you mean the tmu_cpu* node (supplying power to VDD_TS01/23/4)? If yes then you can also change it, like on Odroid XU boards. > > LDO8 is hdmi vdd and vdd_pll supply but it's also used as supply for > the Exynos5420 Display port. > > BUCK2 and BUCK6 are the vdd supplies for the EAGLE and KFC clusters. > > Signed-off-by: Javier Martinez Canillas > --- > > arch/arm/boot/dts/exynos5420-peach-pit.dts | 5 ----- > arch/arm/boot/dts/exynos5800-peach-pi.dts | 5 ----- > 2 files changed, 10 deletions(-) Anyway, Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof