From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755884AbcETMSM (ORCPT ); Fri, 20 May 2016 08:18:12 -0400 Received: from mail-wm0-f54.google.com ([74.125.82.54]:37238 "EHLO mail-wm0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752075AbcETMSK (ORCPT ); Fri, 20 May 2016 08:18:10 -0400 Subject: Re: [PATCH 1/3] reset: Add support for the Amlogic Meson GXBB Reset Controller To: Philipp Zabel References: <1463732875-23141-1-git-send-email-narmstrong@baylibre.com> <1463732875-23141-2-git-send-email-narmstrong@baylibre.com> <1463736478.4322.31.camel@pengutronix.de> Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, xing.xu@amlogic.com, victor.wan@amlogic.com, jerry.cao@amlogic.com From: Neil Armstrong Organization: Baylibre Message-ID: <573F007B.6030502@baylibre.com> Date: Fri, 20 May 2016 14:18:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <1463736478.4322.31.camel@pengutronix.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Philipp, On 05/20/2016 11:27 AM, Philipp Zabel wrote: > Hi Neil, > > Am Freitag, den 20.05.2016, 10:27 +0200 schrieb Neil Armstrong: >> +config MESON_GXBB_RESET >> + tristate "Amlogic Meson GXBB Reset Driver" >> + depends on (ARCH_MESON && RESET_CONTROLLER) > > With the "reset: fix Kconfig menu to include reset drivers in sub-menu" > patch [1] applied this is wrapped in "if RESET_CONTROLLER ... endif", so > no need to depend on RESET_CONTROLLER. > Is there a reason to have this configurable at all, though? > > [1] https://patchwork.kernel.org/patch/9000591/ > > Or drop CONFIG_MESON_GXBB_RESET and use CONFIG_ARCH_MESON directly. No strong reason, I will switch to CONFIG_ARCH_MESON. > [...] > > With the "reset: add devm_reset_controller_register API" patch [2] > applied you can use devm_reset_controller_register() here and remove the > meson_gxbb_reset_remove() function below. > > [2] https://patchwork.kernel.org/patch/8988471/ > >> +} >> + >> +static int meson_gxbb_reset_remove(struct platform_device *pdev) >> +{ >> + struct meson_gxbb_reset *data = platform_get_drvdata(pdev); >> + >> + reset_controller_unregister(&data->rcdev); >> + >> + return 0; >> +} > > Could be removed, then. > > regards > Philipp It will be for sure ! Neil