From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756075AbcETMUj (ORCPT ); Fri, 20 May 2016 08:20:39 -0400 Received: from mail-wm0-f52.google.com ([74.125.82.52]:34192 "EHLO mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756054AbcETMUh (ORCPT ); Fri, 20 May 2016 08:20:37 -0400 Subject: Re: [PATCH 1/3] reset: Add support for the Amlogic Meson GXBB Reset Controller To: Carlo Caione References: <1463732875-23141-1-git-send-email-narmstrong@baylibre.com> <1463732875-23141-2-git-send-email-narmstrong@baylibre.com> <20160520090448.GA19888@mephisto> <573ED483.10101@baylibre.com> <20160520100437.GA21213@mephisto> Cc: xing.xu@amlogic.com, victor.wan@amlogic.com, linux-kernel@vger.kernel.org, p.zabel@pengutronix.de, jerry.cao@amlogic.com, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org From: Neil Armstrong Organization: Baylibre Message-ID: <573F0109.9080302@baylibre.com> Date: Fri, 20 May 2016 14:20:25 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <20160520100437.GA21213@mephisto> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/20/2016 12:04 PM, Carlo Caione wrote: > On 20/05/16 11:10, Neil Armstrong wrote: >> On 05/20/2016 11:04 AM, Carlo Caione wrote: >>> On 20/05/16 10:27, Neil Armstrong wrote: >>>> This patch adds the platform driver for the Amlogic Meson GXBB Reset >>>> Controller. >>>> >>>> Signed-off-by: Neil Armstrong >>>> --- >>>> drivers/reset/Kconfig | 6 ++ >>>> drivers/reset/Makefile | 1 + >>>> drivers/reset/reset-meson-gxbb.c | 129 +++++++++++++++++++++++++++++++++++++++ >>>> 3 files changed, 136 insertions(+) >>>> create mode 100644 drivers/reset/reset-meson-gxbb.c >>> >>> Do we really need to be that specific (-gxbb)? This driver looks generic >>> and simple enough to be used for several Amlogic families. You are >>> already differentiating between them with the include file defining the >>> reset indexes for the SoC. >> >> This is a good question, do the S805 have similar registers ? Same count and width ? >> I no, it should need a rework to add a data structure per-SoC. > > According to the datasheet on S805 we have 7 registers with 16 reset > bits per register. It will fit, I made the change to be generic. Do you know if the meson8 and previous meson6 has these registers ? Neil