From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752806AbcEWFSa (ORCPT ); Mon, 23 May 2016 01:18:30 -0400 Received: from li2-213.members.linode.com ([69.56.173.213]:44314 "EHLO mail.zilogic.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752377AbcEWFS3 (ORCPT ); Mon, 23 May 2016 01:18:29 -0400 Message-ID: <57429270.8060401@zilogic.com> Date: Mon, 23 May 2016 10:47:36 +0530 From: raashidmuhammed User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.8.0 MIME-Version: 1.0 To: Rob Herring , Nicolas Ferre CC: Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , linux@armlinux.org.uk, vijaykumar@bravegnu.org, "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH] ARM: at91: Add DT support for Olimex SAM9-L9260 board. References: <1463574766-15568-1-git-send-email-raashidmuhammed@zilogic.com> <20160518232925.GA6545@rob-hp-laptop> <573DB180.9030200@atmel.com> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/19/2016 06:20 PM, Rob Herring wrote: > On Thu, May 19, 2016 at 7:28 AM, Nicolas Ferre wrote: >> Le 19/05/2016 01:29, Rob Herring a écrit : >>> On Wed, May 18, 2016 at 06:02:46PM +0530, Raashid Muhammed wrote: >>>> From: Raashid Muhammed >>>> >>>> sam9-l9260 is a low cost board designed by Olimex. >>>> >>>> More infomation is available at: >>>> https://www.olimex.com/Products/ARM/Atmel/SAM9-L9260/ >>>> >>>> Signed-off-by: Raashid Muhammed >>>> Reviewed-by: Vijay Kumar B. >>>> --- >>>> .../devicetree/bindings/arm/olimex-at91.txt | 6 ++ >>>> arch/arm/boot/dts/Makefile | 1 + >>>> arch/arm/boot/dts/sam9-l9260.dts | 108 +++++++++++++++++++++ >> For AT91-based boards, please use this prefix: "at91-" as stated in the >> Atmel README file: >> http://lxr.free-electrons.com/source/Documentation/arm/Atmel/README#L127 >> >> So I would recommend this name instead: >> at91-sam9-l9260.dts >> >> >>>> 3 files changed, 115 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/arm/olimex-at91.txt >>>> create mode 100644 arch/arm/boot/dts/sam9-l9260.dts >>>> >>>> diff --git a/Documentation/devicetree/bindings/arm/olimex-at91.txt b/Documentation/devicetree/bindings/arm/olimex-at91.txt >>>> new file mode 100644 >>>> index 0000000..0587d63 >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/arm/olimex-at91.txt >>>> @@ -0,0 +1,6 @@ >>>> +Olimex AT91 Device Tree Bindings >>>> +-------------------------------- >>> There's not an existing at91 or olimex file this would fit into? We >>> don't need 1 file per board. >>> >>>> + >>>> +SAM9-L9260 Board >>>> +Required root node properties: >>>> + - compatible = "olimex,sam9-l9260", "atmel,at91sam9260"; >> I don't think this file is needed at all actually. We have a lot of >> board files and none of them have a dedicated or particular entry for them. > Well, they should have one. > > Rob Thanks everyone for your valuable comments. I'll incorporate the changes and resend the patch. Regards, Raashid