From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753003AbcEWGKa (ORCPT ); Mon, 23 May 2016 02:10:30 -0400 Received: from regular1.263xmail.com ([211.150.99.141]:46939 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752793AbcEWGK3 (ORCPT ); Mon, 23 May 2016 02:10:29 -0400 X-263anti-spam: KSV:0;BIG:0;ABS:1;DNS:0;ATT:0;SPF:S; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ADDR-CHECKED: 0 X-RL-SENDER: mark.yao@rock-chips.com X-FST-TO: linux-kernel@vger.kernel.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: mark.yao@rock-chips.com X-UNIQUE-TAG: <1ffec99fe0598f5a5468a5302413ea41> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH 0/3] drm/rockchip: fix some sparse warnings To: John Keeping References: <20160510160356.1167-1-john@metanate.com> Cc: David Airlie , Heiko Stuebner , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org From: Mark yao Message-ID: <57429EC8.4080207@rock-chips.com> Date: Mon, 23 May 2016 14:10:16 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20160510160356.1167-1-john@metanate.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016年05月11日 00:03, John Keeping wrote: > The first patch wasn't found by sparse, but is something I noticed while > in the area. The following two fix all of the sparse warnings inside > drm/rockchip. > > John Keeping (3): > drm/rockchip: dw_hdmi: remove unused #include > drm/rockchip: fb: add missing header > drm/rockchip: fix "should it be static?" warnings > > drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 1 - > drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 4 ++-- > drivers/gpu/drm/rockchip/rockchip_drm_fb.c | 7 ++++--- > drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 4 ++-- > drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 2 +- > 5 files changed, 9 insertions(+), 9 deletions(-) > Hi John Sorry for reply late, this series of patches looks good for me, Applied to my branch. Thanks. -- Mark Yao