* [PATCH] KVM: Unify traced vector format
@ 2016-05-23 6:43 Jan Kiszka
2016-05-23 12:26 ` Paolo Bonzini
0 siblings, 1 reply; 2+ messages in thread
From: Jan Kiszka @ 2016-05-23 6:43 UTC (permalink / raw)
To: Paolo Bonzini, Radim Krčmář; +Cc: kvm, Linux Kernel Mailing List
Specifically the change from hex to decimal helps correlating events.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
include/trace/events/kvm.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/trace/events/kvm.h b/include/trace/events/kvm.h
index 526fb3d..f28292d 100644
--- a/include/trace/events/kvm.h
+++ b/include/trace/events/kvm.h
@@ -108,7 +108,7 @@ TRACE_EVENT(kvm_ioapic_set_irq,
__entry->coalesced = coalesced;
),
- TP_printk("pin %u dst %x vec=%u (%s|%s|%s%s)%s",
+ TP_printk("pin %u dst %x vec %u (%s|%s|%s%s)%s",
__entry->pin, (u8)(__entry->e >> 56), (u8)__entry->e,
__print_symbolic((__entry->e >> 8 & 0x7), kvm_deliver_mode),
(__entry->e & (1<<11)) ? "logical" : "physical",
@@ -129,7 +129,7 @@ TRACE_EVENT(kvm_ioapic_delayed_eoi_inj,
__entry->e = e;
),
- TP_printk("dst %x vec=%u (%s|%s|%s%s)",
+ TP_printk("dst %x vec %u (%s|%s|%s%s)",
(u8)(__entry->e >> 56), (u8)__entry->e,
__print_symbolic((__entry->e >> 8 & 0x7), kvm_deliver_mode),
(__entry->e & (1<<11)) ? "logical" : "physical",
@@ -151,7 +151,7 @@ TRACE_EVENT(kvm_msi_set_irq,
__entry->data = data;
),
- TP_printk("dst %u vec %x (%s|%s|%s%s)",
+ TP_printk("dst %u vec %u (%s|%s|%s%s)",
(u8)(__entry->address >> 12), (u8)__entry->data,
__print_symbolic((__entry->data >> 8 & 0x7), kvm_deliver_mode),
(__entry->address & (1<<2)) ? "logical" : "physical",
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] KVM: Unify traced vector format
2016-05-23 6:43 [PATCH] KVM: Unify traced vector format Jan Kiszka
@ 2016-05-23 12:26 ` Paolo Bonzini
0 siblings, 0 replies; 2+ messages in thread
From: Paolo Bonzini @ 2016-05-23 12:26 UTC (permalink / raw)
To: Jan Kiszka, Radim Krčmář; +Cc: kvm, Linux Kernel Mailing List
On 23/05/2016 08:43, Jan Kiszka wrote:
> Specifically the change from hex to decimal helps correlating events.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> include/trace/events/kvm.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/trace/events/kvm.h b/include/trace/events/kvm.h
> index 526fb3d..f28292d 100644
> --- a/include/trace/events/kvm.h
> +++ b/include/trace/events/kvm.h
> @@ -108,7 +108,7 @@ TRACE_EVENT(kvm_ioapic_set_irq,
> __entry->coalesced = coalesced;
> ),
>
> - TP_printk("pin %u dst %x vec=%u (%s|%s|%s%s)%s",
> + TP_printk("pin %u dst %x vec %u (%s|%s|%s%s)%s",
> __entry->pin, (u8)(__entry->e >> 56), (u8)__entry->e,
> __print_symbolic((__entry->e >> 8 & 0x7), kvm_deliver_mode),
> (__entry->e & (1<<11)) ? "logical" : "physical",
> @@ -129,7 +129,7 @@ TRACE_EVENT(kvm_ioapic_delayed_eoi_inj,
> __entry->e = e;
> ),
>
> - TP_printk("dst %x vec=%u (%s|%s|%s%s)",
> + TP_printk("dst %x vec %u (%s|%s|%s%s)",
> (u8)(__entry->e >> 56), (u8)__entry->e,
> __print_symbolic((__entry->e >> 8 & 0x7), kvm_deliver_mode),
> (__entry->e & (1<<11)) ? "logical" : "physical",
> @@ -151,7 +151,7 @@ TRACE_EVENT(kvm_msi_set_irq,
> __entry->data = data;
> ),
>
> - TP_printk("dst %u vec %x (%s|%s|%s%s)",
> + TP_printk("dst %u vec %u (%s|%s|%s%s)",
> (u8)(__entry->address >> 12), (u8)__entry->data,
> __print_symbolic((__entry->data >> 8 & 0x7), kvm_deliver_mode),
> (__entry->address & (1<<2)) ? "logical" : "physical",
>
Looks good, thanks.
Paolo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-05-23 12:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-23 6:43 [PATCH] KVM: Unify traced vector format Jan Kiszka
2016-05-23 12:26 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox