From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754877AbcEWNSO (ORCPT ); Mon, 23 May 2016 09:18:14 -0400 Received: from mail-wm0-f46.google.com ([74.125.82.46]:37268 "EHLO mail-wm0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752991AbcEWNSM (ORCPT ); Mon, 23 May 2016 09:18:12 -0400 Subject: Re: [PATCH V5 3/6] vfio: platform: determine reset capability To: Sinan Kaya , kvm@vger.kernel.org, timur@codeaurora.org, cov@codeaurora.org, jcm@redhat.com References: <1463364819-477-1-git-send-email-okaya@codeaurora.org> <1463364819-477-4-git-send-email-okaya@codeaurora.org> Cc: linux-acpi@vger.kernel.org, agross@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Baptiste Reynal , Alex Williamson , linux-kernel@vger.kernel.org From: Eric Auger Message-ID: <574302B7.7010605@linaro.org> Date: Mon, 23 May 2016 15:16:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1463364819-477-4-git-send-email-okaya@codeaurora.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/16/2016 04:13 AM, Sinan Kaya wrote: > Creating a new function to determine if this driver supports reset > function or not. This is an attempt to abstract device tree calls > from the rest of the code. > > Signed-off-by: Sinan Kaya > --- > drivers/vfio/platform/vfio_platform_common.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/vfio/platform/vfio_platform_common.c b/drivers/vfio/platform/vfio_platform_common.c > index cb91dd3..25378bd 100644 > --- a/drivers/vfio/platform/vfio_platform_common.c > +++ b/drivers/vfio/platform/vfio_platform_common.c > @@ -49,6 +49,11 @@ static vfio_platform_reset_fn_t vfio_platform_lookup_reset(const char *compat, > return reset_fn; > } > > +static bool vfio_platform_has_reset(struct vfio_platform_device *vdev) > +{ > + return vdev->of_reset ? true : false; > +} > + > static void vfio_platform_get_reset(struct vfio_platform_device *vdev) > { > vdev->of_reset = vfio_platform_lookup_reset(vdev->compat, > @@ -215,7 +220,7 @@ static long vfio_platform_ioctl(void *device_data, > if (info.argsz < minsz) > return -EINVAL; > > - if (vdev->of_reset) > + if (vfio_platform_has_reset(vdev)) > vdev->flags |= VFIO_DEVICE_FLAGS_RESET; > info.flags = vdev->flags; > info.num_regions = vdev->num_regions; > Reviewed-by: Eric Auger Eric