From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Muhammad Falak R Wani <falakreyaz@gmail.com>
Cc: David Vrabel <david.vrabel@citrix.com>,
Juergen Gross <jgross@suse.com>,
"moderated list:XEN HYPERVISOR INTERFACE"
<xen-devel@lists.xenproject.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] xen/privcmd: use vma_pages().
Date: Mon, 23 May 2016 16:26:37 -0400 [thread overview]
Message-ID: <5743677D.7030603@oracle.com> (raw)
In-Reply-To: <1463836161-16524-1-git-send-email-falakreyaz@gmail.com>
On 05/21/2016 09:09 AM, Muhammad Falak R Wani wrote:
> Replace explicit computation of vma page count by a call to
> vma_pages()
>
> Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
> ---
> drivers/xen/privcmd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/xen/privcmd.c b/drivers/xen/privcmd.c
> index df2e6f7..702040f 100644
> --- a/drivers/xen/privcmd.c
> +++ b/drivers/xen/privcmd.c
> @@ -582,7 +582,7 @@ static long privcmd_ioctl(struct file *file,
> static void privcmd_close(struct vm_area_struct *vma)
> {
> struct page **pages = vma->vm_private_data;
> - int numpgs = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT;
> + int numpgs = vma_pages(vma);
> int numgfns = (vma->vm_end - vma->vm_start) >> XEN_PAGE_SHIFT;
> int rc;
>
Can you combine all three patches into a single one?
Thanks.
-boris
next prev parent reply other threads:[~2016-05-23 20:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-21 13:09 [PATCH] xen/privcmd: use vma_pages() Muhammad Falak R Wani
2016-05-21 13:09 ` [PATCH] xen/gntdev: " Muhammad Falak R Wani
2016-05-21 13:09 ` [PATCH] xen/gntalloc: " Muhammad Falak R Wani
2016-05-23 20:26 ` Boris Ostrovsky [this message]
2016-05-24 0:07 ` [PATCH] xen/privcmd: " Muhammad Falak R Wani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5743677D.7030603@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=falakreyaz@gmail.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox