From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A51F33314B7 for ; Thu, 11 Jun 2026 04:18:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781151511; cv=none; b=iLg0/gw02J+TBb328QSZJKD5s1rPNne+5RY5cng6TMw16ZZyn+mJp9O5596NQzv62EJj+soIQ15WoFpwoxr8ELsBtDKMocV8xkJhAHC7oB0dfq4/dvzGTqWlXplvLP9GVGD3F7Hbfyo5eAWdECfdgVU+ocwcbBBIGWx7Tq0yK2c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781151511; c=relaxed/simple; bh=Rb/ACdmsEm+RU92dEhfaeEiN+gtsfcyLcKHnFtGbGwc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=rqirV8ezXNRn2QjErTtt4B+89DXO0PIdPtnjlAoPKgC7jLNgpgon9ZD7fZBJFoREQAcynAUNAvCUePUHHqq/hZvTzfX6Zx4YIofYn4ooQ9J2x+hhZM5U1bSkERHXHPUc4iOyJ1HcZcye19gmiatCF9STl4wwrsn/TfDtP52I6gY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=ck2I0481; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="ck2I0481" Received: from pps.filterd (m0360072.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65AJuDmo677708; Thu, 11 Jun 2026 04:18:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=v5S3zT +XXW2ygKvgVTdNnT0Bu2J/zloh3YLeZvv+Wq4=; b=ck2I04817QcJrQzLluSKnB /pzuz32wzC5nMWMVhBI4Ju+nVhBb5+332ePBFB20wLYBpwPlSEdOcYsFyP+p7ziH yrPTB8cMUqHSbz3ZBJ1SyjkpNnH7z5n9HvxJISdtpxcWFvAwpV/EhKuhQOI7avT/ yJNig71XVB5IVYi/Bhg/5KHijSRujN/uunmvIT3KCVjbyLhTHI/U6ARXzRBRF+xU dfU77daJZ4/5z73YZo03JqRA567P8Aq2VDwWxU2Uv53bXGd3OP0BLycvnxdq7vDr Y0PMZpua6K9TZ9TW+GCyDkEJotjSTxw4kQHvU5da8EIdcnkXSMBshQoh3SQ1ewiA == Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4eqe8ahbdb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 11 Jun 2026 04:18:06 +0000 (GMT) Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id 65B44bfA024503; Thu, 11 Jun 2026 04:18:06 GMT Received: from smtprelay06.dal12v.mail.ibm.com ([172.16.1.8]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4eqe0a1jpf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 11 Jun 2026 04:18:06 +0000 (GMT) Received: from smtpav06.dal12v.mail.ibm.com (smtpav06.dal12v.mail.ibm.com [10.241.53.105]) by smtprelay06.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 65B4I5iK29950618 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 11 Jun 2026 04:18:05 GMT Received: from smtpav06.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3ECAA58055; Thu, 11 Jun 2026 04:18:05 +0000 (GMT) Received: from smtpav06.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2C77958043; Thu, 11 Jun 2026 04:18:02 +0000 (GMT) Received: from [9.43.60.77] (unknown [9.43.60.77]) by smtpav06.dal12v.mail.ibm.com (Postfix) with ESMTP; Thu, 11 Jun 2026 04:18:01 +0000 (GMT) Message-ID: <57438008-47e2-4a83-8a01-a6554d0eaf2d@linux.ibm.com> Date: Thu, 11 Jun 2026 09:48:00 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 04/15] nvme: add Clang context annotations for nvme_ns_head::requeue_list To: Bart Van Assche , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Cc: hch@lst.de, kbusch@kernel.org, sagi@grimberg.me, axboe@fb.com, elver@google.com, gjoyce@linux.ibm.com References: <20260610142743.115898-1-nilay@linux.ibm.com> <20260610142743.115898-5-nilay@linux.ibm.com> <0b3ab980-db78-4f21-8af7-f74961f5d648@acm.org> Content-Language: en-US From: Nilay Shroff In-Reply-To: <0b3ab980-db78-4f21-8af7-f74961f5d648@acm.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Proofpoint-ORIG-GUID: onCxt1_Q1vOyJ9y43XVHnIouEiTpKtoY X-Authority-Analysis: v=2.4 cv=TdKmcxQh c=1 sm=1 tr=0 ts=6a2a36ff cx=c_pps a=3Bg1Hr4SwmMryq2xdFQyZA==:117 a=3Bg1Hr4SwmMryq2xdFQyZA==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=RzCfie-kr_QcCd8fBx8p:22 a=P2YX_yz4t0Xk7t2HBcYA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjExMDAzNyBTYWx0ZWRfXyZzK3oOD/RW9 VNRlqdmdKIpJqzqEn5G2YnvdtHhWh8GFKJdAQjFCd+qRsOIdY+/po/xWbHbH/NwHWxxF9jIWpiH 3zkaJYUiWVLyEmFRwpcEb6HGJci+iGh88wUa/roBXolTpcVGxum7R8Nd2fihcuWrqjEUmtUmXyl xIAYX49lDfmUgXx0g6Bc6lX7XpInQzZ9pSMt7NkxhlxPisBj353HF3yuHfXjuDw5vSOOgxLHb0I q9LrqZv/KynzpSa2+FHEd24YEq4Evn4n0tyHQdWFVT0dq1URAcDMIppYq2UWF5ANGSsGVSdXLkc iVO1VGli3PgkyHiieuf/7ypxxQG4/Zx6nMU6xs7FronW40jvvDwsOjU7qbpon0v3Eq2J22mmOte lzc/J5HKM5h79RxGND2iWok3/rIRfPUcdm7hMYD6kevsYgU9WQZgmOAcds/yE9ROrWhPTbgHhpy oo1oZFUfIt4TPMOczNw== X-Proofpoint-GUID: EVZdQ0itDVekK_aFhxSZhe9Ds3d8JoLk X-Proofpoint-Spam-Info: AW1haW4tMjYwNjExMDAzNyBTYWx0ZWRfXwoFZnzZTN7rF ZsHMuspDCMJLuUQM6c+hzqTFXHy+0k0PXbM2Qv4tjG6TVtRdjuk8kyKnmtYup26FjYZbYOQcdWY b+ugF3xARHHBewdprjL/3GlwSKqnWa4= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-11_01,2026-06-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 malwarescore=0 clxscore=1015 impostorscore=0 adultscore=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606110037 On 6/10/26 9:55 PM, Bart Van Assche wrote: > On 6/10/26 7:27 AM, Nilay Shroff wrote: >> diff --git a/drivers/nvme/host/multipath.c b/drivers/nvme/host/multipath.c >> index a275c03e7c59..985a8c693c6f 100644 >> --- a/drivers/nvme/host/multipath.c >> +++ b/drivers/nvme/host/multipath.c >> @@ -706,8 +706,8 @@ int nvme_mpath_alloc_disk(struct nvme_ctrl *ctrl, struct nvme_ns_head *head) >>       struct queue_limits lim; >>       mutex_init(&head->lock); >> +    guard(spinlock_init)(&head->requeue_lock); >>       bio_list_init(&head->requeue_list); >> -    spin_lock_init(&head->requeue_lock); > scoped_guard() is preferred over guard() because with scoped_guard() the > scope the guard applies to is explicit. When using guard(), if new code > is added, it may end up being covered by a guard() statement although it > shouldn't. > Yes makes sense, I'll replace guard() with scoped_guard(). Thanks, --Nilay