From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752884AbbJMMSu (ORCPT ); Tue, 13 Oct 2015 08:18:50 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:59136 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752248AbbJMMSp (ORCPT ); Tue, 13 Oct 2015 08:18:45 -0400 From: Arnd Bergmann To: John Garry Cc: James.Bottomley@hansenpartnership.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linuxarm@huawei.com, zhangfei.gao@linaro.org, linux-scsi@vger.kernel.org, xuwei5@hisilicon.com, john.garry2@mail.dcu.ie, hare@suse.de Subject: Re: [PATCH 04/25] scsi: hisi_sas: add scsi host registration Date: Tue, 13 Oct 2015 14:18:33 +0200 Message-ID: <5744202.hTVSbkLqE4@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <561CCC07.2090901@huawei.com> References: <1444663237-238302-1-git-send-email-john.garry@huawei.com> <5053179.dHmgEztyeB@wuerfel> <561CCC07.2090901@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:avmopwXPfyqkrOhX6Cc2b+5v98cZArMGeAghN8FUvVY2Jy7w4hU +HTAHtBmsSl7P2gsIDg+zPyfrjEVboShE1XIYVLIpkQDriQCK7MBMSPB12QA2ScutqZ6m1P WhOrnY5lvULva57VLh7pdawAzQLnBhcUxKlKSmpw9mvkO0jlkUDz2NEtFHDA6Duvhr0LsW1 CnaQGXuqyFGrifj+DJYgw== X-UI-Out-Filterresults: notjunk:1;V01:K0:qyR5CHHIRC8=:8ok8mx2OoattQfMjn0BIm7 n0gbyfMXNKn/5VJx+h+UYrlD3dUM7Fn/rBN6nFIkcjGvJyUu1kHh1AlVtmROqsYAcmy21Cbm4 41jss8QUJvHR8KeCmjVuFN8kMBNr0qc9ceNboGtq6WCl+gf0zgDBxu8f5Mn3jirxw9GCagXVK EYiEqtDyAHA5BekK4tbIv9XDh1amcx62ntoQ6nu/vR4rYP9I1h1m5BymD48h5ue2LpGe70PRd lfR7NC5Hn541MExwDSB9T6kUZqVQBt2nKJW4TrMJVT1ml+koxALt+VfrUCJHy70Lg54mbcx06 CR1YxQbbtxDHi1sxYbxTMWQxEkgdG5NQsnXxBLQkPozXOxupHnjcGNU79rHFS8PRbRzy9aXo9 C8d+V7ctqhtlq51E1f3X1wgdN7JZks0kph0OS9TOKzy8AQ9jKc1RFsh0Ud5ZL78zh9ULfnUJh L0VM5oRN6u1DkA2nnVFNL90yeO4Erfg882uW2YduoKuEr4kEvyN5mX7koPVy/pGvvgXxPIlrr GYCsLLtwr87kqhEDlAXF+ydl6QZBBMwcgDyY9MnvbkuAWp1SEU2BoAzBM36mGWX/thhhnRm1G DrqRGP7f9MO7JWYQsYy9PdDDemDXmpHgH97qvKiXlfnf3cbrL6nZL5MQB4R7RKFlrXGpHNlYn mqNaOQxDYZ2tVqlhonLAtH3pMFGafzgUSliqIxHUMoLFVb/d6eyLyBKqv5YTKl5taXcm/djYE 746swC5FRZeSVHT9 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 13 October 2015 10:16:55 John Garry wrote: > > > > >> + sha = SHOST_TO_SAS_HA(shost) = &hisi_hba->sha; > >> + platform_set_drvdata(pdev, sha); > >> + > >> + phy_nr = port_nr = HISI_SAS_MAX_PHYS; > >> + > >> + arr_phy = devm_kcalloc(dev, phy_nr, sizeof(void *), GFP_KERNEL); > >> + arr_port = devm_kcalloc(dev, port_nr, sizeof(void *), GFP_KERNEL); > >> + if (!arr_phy || !arr_port) > >> + return -ENOMEM; > > > > And since these are fixed-size arrays, they can be moved in there as well. > > > In a later patch we set as follows: > phy_nr = port_nr = hisi_hba->n_phy; > > You did say in our earlier private review that we could add statically > to hba strcut, but I commented that other vendors do similar so I would > wait for more input. Ok, I forgot about that. Arnd