From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755629AbcEXKUQ (ORCPT ); Tue, 24 May 2016 06:20:16 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:48526 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751570AbcEXKUN (ORCPT ); Tue, 24 May 2016 06:20:13 -0400 X-AuditID: cbfee68d-f79646d000001386-54-57442ad85473 Message-id: <57442AD8.6030708@samsung.com> Date: Tue, 24 May 2016 19:20:08 +0900 From: Jaehoon Chung User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-version: 1.0 To: Shawn Lin , Ulf Hansson Cc: Adrian Hunter , Michal Simek , soren.brinkmann@xilinx.com, Rob Herring , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Doug Anderson , Brian Norris , Heiko Stuebner , linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org Subject: Re: [PATCH v5 2/5] mmc: core: add mmc-hs400-enhanced-strobe support References: <1463976789-29618-1-git-send-email-shawn.lin@rock-chips.com> <1463976823-29739-1-git-send-email-shawn.lin@rock-chips.com> In-reply-to: <1463976823-29739-1-git-send-email-shawn.lin@rock-chips.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrEIsWRmVeSWpSXmKPExsWyRsSkWPeGlku4wYFWcYuTT9awWWz6+J7V Yv6Rc6wWZ5cdZLP4/+g1q8XlXXPYLI7872e0+PTgP7PFu5cRFq17j7Bb3HmyntXi5o7N7BbH 14Y78HrMbrjI4rF4z0smj02rOtk87lzbw+axeUm9x99Z+1k8tl+bx+zxeZOcx97Pv1kCOKO4 bFJSczLLUov07RK4MroePmAueClS0b6zma2BsV2wi5GTQ0LAROLBmV52CFtM4sK99WxdjFwc QgIrGCVub9vCDFP0fdEfVojEUkaJNVtXMEM4DxglFj5cA1bFK6Al8efUfBYQm0VAVaL79m9W EJtNQEdi+7fjTCC2qECYxIN1e1kh6gUlfky+B1YvIuAnsXXHVrDVzAJtzBKHfi5g7GLk4BAW 8JF4etwaYtltRokDy6aBLeMU8JQ40L6FFaSGWUBP4v5FLZAws4C8xOY1b8GOkxCYyyHxa9EC NoiDBCS+TT7EAlIvISArsekA1GeSEgdX3GCZwCg2C8lJsxCmzkIydQEj8ypG0dSC5ILipPQi Q73ixNzi0rx0veT83E2MwKg+/e9Z7w7G2wesDzEKcDAq8fBuOOwcLsSaWFZcmXuI0RToiInM UqLJ+cDUkVcSb2hsZmRhamJqbGRuaaYkzqso9TNYSCA9sSQ1OzW1ILUovqg0J7X4ECMTB6dU A6PIRfVo3cCnh+SUtzwvSXrnse3TouhtSYVdcU0v/Gd/PW8TpbIlzvLBrSSWye2ibxKPvTct 4cjkZQ6b3R8W/en88rnPRJ6GxhUoWi6aqWCiOG2uo/c6xqxZoUlx6+YG9H9b8IqH09jpyJcQ bglVq+1FZ4SurxE8p3SY6+p5jmUT9s24relwPkeJpTgj0VCLuag4EQB5uik25QIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprPKsWRmVeSWpSXmKPExsVy+t9jAd0bWi7hBr3XBSxOPlnDZrHp43tW i/lHzrFanF12kM3i/6PXrBaXd81hszjyv5/R4tOD/8wW715GWLTuPcJucefJelaLmzs2s1sc XxvuwOsxu+Eii8fiPS+ZPDat6mTzuHNtD5vH5iX1Hn9n7Wfx2H5tHrPH501yHns//2YJ4Ixq YLTJSE1MSS1SSM1Lzk/JzEu3VfIOjneONzUzMNQ1tLQwV1LIS8xNtVVy8QnQdcvMATpbSaEs MacUKBSQWFyspG+HaUJoiJuuBUxjhK5vSBBcj5EBGkhYw5jR9fABc8FLkYr2nc1sDYztgl2M nBwSAiYS3xf9YYWwxSQu3FvP1sXIxSEksJRRYs3WFcwQzgNGiYUP1zCDVPEKaEn8OTWfBcRm EVCV6L79G6ybTUBHYvu340wgtqhAmMSDdXtZIeoFJX5MvgdWLyLgJ7F1x1awDcwCbcwSh34u YOxi5OAQFvCReHrcGmLZbUaJA8umgS3jFPCUONC+hRWkhllAT+L+RS2QMLOAvMTmNW+ZJzAK zEKyYhZC1SwkVQsYmVcxSqQWJBcUJ6XnGuWllusVJ+YWl+al6yXn525iBCeOZ9I7GA/vcj/E KMDBqMTDG5DvHC7EmlhWXJl7iFGCg1lJhFcMmHaEeFMSK6tSi/Lji0pzUosPMZoCw2Ais5Ro cj4wqeWVxBsam5gZWRqZG1oYGZsrifM+/r8uTEggPbEkNTs1tSC1CKaPiYNTqoFx8e2TK1Lk 7lp7vHvs90PQLubDhP0PFNN3cp3dY/fz3vY/etPWKF2f66LU3mUiy2af+/SbvsO7U+993Lp6 Vk8xObNdmF3l7hSDu9y91RMfvHN02fzocF/BtQknY079frbs7OVJegWa+TO/rbyVPeVs/639 XZmbGTTXXtvs+/EKm+EvrXytJi2Bp0osxRmJhlrMRcWJAJZkXAUyAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/23/2016 01:13 PM, Shawn Lin wrote: > This patch introduce mmc-hs400-enhanced-strobe for platforms > which want to enable enhanced strobe function from DT if the > mmc host controller claims to support enhanced strobe. > > Signed-off-by: Shawn Lin Tested-by: Jaehoon Chung Best Regards, Jaehoon Chung > > --- > > Changes in v5: > - avoid to call hs400_enhanced+_strobe in mmc_set_initial_state > if no setting MMC_CAP2_HS400_ES. > - add Adrian's ack for patch[5/5] > > Changes in v4: > - check avail_type with EXT_CSD_CARD_TYPE_HS400 instead of > card_type > - check if host support 8-bit when selecting hs400es > - some minor fix suggested by Douglas and add his review tag > > Changes in v3: > - remove helper function and shorten cap2 to MMC_CAP2_HS400_ES > - rename callback to hs400_enhanced_strobe and make it return void > - add enhanced_strobe in mmc_ios and pass it to hs400_enhanced_strobe > - disable host's enhanced strobe in mmc_set_initial_state > - remove bus checking after switching hs400es > - add new function for hs400es timing selection > - fix wrong judgement of mmc_card_hs400es > > Changes in v2: > - switch to HS400ES from Highspeed mode directly > > drivers/mmc/core/host.c | 2 ++ > include/linux/mmc/host.h | 1 + > 2 files changed, 3 insertions(+) > > diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c > index e0a3ee1..45773e4 100644 > --- a/drivers/mmc/core/host.c > +++ b/drivers/mmc/core/host.c > @@ -289,6 +289,8 @@ int mmc_of_parse(struct mmc_host *host) > host->caps2 |= MMC_CAP2_HS400_1_8V | MMC_CAP2_HS200_1_8V_SDR; > if (of_property_read_bool(np, "mmc-hs400-1_2v")) > host->caps2 |= MMC_CAP2_HS400_1_2V | MMC_CAP2_HS200_1_2V_SDR; > + if (of_property_read_bool(np, "mmc-hs400-enhanced-strobe")) > + host->caps2 |= MMC_CAP2_HS400_ES; > > host->dsr_req = !of_property_read_u32(np, "dsr", &host->dsr); > if (host->dsr_req && (host->dsr & ~0xffff)) { > diff --git a/include/linux/mmc/host.h b/include/linux/mmc/host.h > index 85800b4..2a06fb0 100644 > --- a/include/linux/mmc/host.h > +++ b/include/linux/mmc/host.h > @@ -302,6 +302,7 @@ struct mmc_host { > #define MMC_CAP2_SDIO_IRQ_NOTHREAD (1 << 17) > #define MMC_CAP2_NO_WRITE_PROTECT (1 << 18) /* No physical write protect pin, assume that card is always read-write */ > #define MMC_CAP2_NO_SDIO (1 << 19) /* Do not send SDIO commands during initialization */ > +#define MMC_CAP2_HS400_ES (1 << 20) /* Host supports enhanced strobe */ > > mmc_pm_flag_t pm_caps; /* supported pm features */ > >