From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755816AbcEXLTf (ORCPT ); Tue, 24 May 2016 07:19:35 -0400 Received: from hqemgate16.nvidia.com ([216.228.121.65]:9699 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752915AbcEXLTd (ORCPT ); Tue, 24 May 2016 07:19:33 -0400 X-PGP-Universal: processed; by hqnvupgp08.nvidia.com on Tue, 24 May 2016 04:18:00 -0700 Message-ID: <574435EA.5010908@nvidia.com> Date: Tue, 24 May 2016 16:37:22 +0530 From: Laxman Dewangan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Linus Walleij CC: Rob Herring , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-gpio@vger.kernel.org" Subject: Re: [PATCH V12 2/2] gpio: max77620: add gpio driver for MAX77620/MAX20024 References: <1463116755-30469-1-git-send-email-ldewangan@nvidia.com> <1463116755-30469-3-git-send-email-ldewangan@nvidia.com> In-Reply-To: X-Originating-IP: [10.19.65.30] X-ClientProxiedBy: BGMAIL104.nvidia.com (10.25.59.13) To bgmail102.nvidia.com (10.25.59.11) Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 24 May 2016 04:45 PM, Linus Walleij wrote: > On Fri, May 13, 2016 at 7:19 AM, Laxman Dewangan wrote: > >> MAXIM Semiconductor's PMIC, MAX77620/MAX20024 has 8 GPIO >> pins. It also supports interrupts from these pins. >> >> Add GPIO driver for these pins to control via GPIO APIs. >> >> Signed-off-by: Laxman Dewangan >> Reviewed-by: Linus Walleij > PS, please add these optional features: > >> + mgpio->gpio_chip.direction_input = max77620_gpio_dir_input; >> + mgpio->gpio_chip.direction_output = max77620_gpio_dir_output; > Any chance you could send a patch to add a .get_direction() callback? Sure, I will send the patch for this and also for the set_single_ended(). I will post the patch on top of this patch as a new patch as this is already applied in your tree. Later on, it can be squashed or added as new patch.