From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758019AbcAKB5W (ORCPT ); Sun, 10 Jan 2016 20:57:22 -0500 Received: from galahad.ideasonboard.com ([185.26.127.97]:43306 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757760AbcAKB5V (ORCPT ); Sun, 10 Jan 2016 20:57:21 -0500 From: Laurent Pinchart To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Sakari Ailus , Nikhil Devshatwar , Mauro Carvalho Chehab , Sylwester Nawrocki , Hans Verkuil , linux-media@vger.kernel.org Subject: Re: [PATCH 1/8] [media] v4l: of: Correct v4l2_of_parse_endpoint() kernel-doc Date: Mon, 11 Jan 2016 03:57:32 +0200 Message-ID: <5744371.YiWThJLWUr@avalon> User-Agent: KMail/4.14.8 (Linux/4.1.12-gentoo; KDE/4.14.8; x86_64; ; ) In-Reply-To: <1452191248-15847-2-git-send-email-javier@osg.samsung.com> References: <1452191248-15847-1-git-send-email-javier@osg.samsung.com> <1452191248-15847-2-git-send-email-javier@osg.samsung.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Javier, Thank you for the patch. On Thursday 07 January 2016 15:27:15 Javier Martinez Canillas wrote: > The v4l2_of_parse_endpoint function kernel-doc says that the return value > is always 0. But that is not true since the function can fail and a error > negative code is returned on failure. So correct the kernel-doc to match. > > Signed-off-by: Javier Martinez Canillas Reviewed-by: Laurent Pinchart > --- > > drivers/media/v4l2-core/v4l2-of.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/v4l2-core/v4l2-of.c > b/drivers/media/v4l2-core/v4l2-of.c index b27cbb1f5afe..93b33681776c 100644 > --- a/drivers/media/v4l2-core/v4l2-of.c > +++ b/drivers/media/v4l2-core/v4l2-of.c > @@ -146,7 +146,7 @@ static void v4l2_of_parse_parallel_bus(const struct > device_node *node, * variable without a low fixed limit. Please use > * v4l2_of_alloc_parse_endpoint() in new drivers instead. > * > - * Return: 0. > + * Return: 0 on success or a negative error code on failure. > */ > int v4l2_of_parse_endpoint(const struct device_node *node, > struct v4l2_of_endpoint *endpoint) -- Regards, Laurent Pinchart