From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755549AbcEXOQb (ORCPT ); Tue, 24 May 2016 10:16:31 -0400 Received: from mail-wm0-f41.google.com ([74.125.82.41]:35709 "EHLO mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751969AbcEXOQ3 (ORCPT ); Tue, 24 May 2016 10:16:29 -0400 Subject: Re: [RFC PATCH] usb: gadget: Introduce Cadence USB2 UDC Driver To: Felipe Balbi , Greg Kroah-Hartman , Laurent Pinchart , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org References: <56210FB1.4030507@baylibre.com> <87ziydncuj.fsf@saruman.tx.rr.com> From: Neil Armstrong Organization: Baylibre Message-ID: <57446230.6000208@baylibre.com> Date: Tue, 24 May 2016 16:16:16 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <87ziydncuj.fsf@saruman.tx.rr.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="3qf7LJncQmmWijVAtf9HlaCkc9X3PEuOv" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --3qf7LJncQmmWijVAtf9HlaCkc9X3PEuOv Content-Type: multipart/mixed; boundary="ge1oeF7Sk9vPPOB16waPPVpmPIMbFgMpS" From: Neil Armstrong To: Felipe Balbi , Greg Kroah-Hartman , Laurent Pinchart , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Message-ID: <57446230.6000208@baylibre.com> Subject: Re: [RFC PATCH] usb: gadget: Introduce Cadence USB2 UDC Driver References: <56210FB1.4030507@baylibre.com> <87ziydncuj.fsf@saruman.tx.rr.com> In-Reply-To: <87ziydncuj.fsf@saruman.tx.rr.com> --ge1oeF7Sk9vPPOB16waPPVpmPIMbFgMpS Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Hi Felipe, Laurent, I submitted this driver for a Cadence IP library from a now abandoned pro= ject. The driver was working on a SoC platform ported on a FPGA, but I do not h= ave access to this HW anymore. But I have a fixed version... Now, I am looking for SoCs, vendors and even Cadence people (or even Evat= ronix employees who worked on this IP before being in Cadence portfolio) to push this driver upstream by testing it on a real HW or even FPGA. I hope this message in a bottle will get read ! Regards, Neil On 11/16/2015 05:11 PM, Felipe Balbi wrote: >=20 > Hi, >=20 > Neil Armstrong writes: >> Introduces UDC support for the Device-Mode only version of the >> Cadence USB2 Controller IP Core. >> >> Host mode and OTG mode are not implemented by lack of hardware. >> Support for Isochronous endpoints is not implemented by lack of time. >> >> Internal DMA is supported and can be activated by DT property. >> >> Signed-off-by: Neil Armstrong >=20 > looks like there are a few checkpatch warnings to be fixed: >=20 > WARNING: added, moved or deleted file(s), does MAINTAINERS need updatin= g? > #89:=20 > new file mode 100644 >=20 > WARNING: 'tranfer' may be misspelled - perhaps 'transfer'? > #233: FILE: drivers/usb/gadget/udc/cadence_hsudc.c:44: > + * - EP Bulk and Interrupt tranfer >=20 > WARNING: Avoid crashing the kernel - try using WARN_ON & recovery code = rather than BUG() or BUG_ON() > #968: FILE: drivers/usb/gadget/udc/cadence_hsudc.c:779: > + BUG(); >=20 > WARNING: Avoid crashing the kernel - try using WARN_ON & recovery code = rather than BUG() or BUG_ON() > #1492: FILE: drivers/usb/gadget/udc/cadence_hsudc.c:1303: > + BUG(); >=20 > WARNING: DT compatible string "cdns,usbhs-udc" appears un-documented --= check workspace/linux/Documentation/devicetree/bindings/ > #1882: FILE: drivers/usb/gadget/udc/cadence_hsudc.c:1693: > + { .compatible =3D "cdns,usbhs-udc" }, >=20 > WARNING: 'tranfer' may be misspelled - perhaps 'transfer'? > #2603: FILE: drivers/usb/gadget/udc/cadence_hsudc_regs.h:272: > +#define HSUDC_DMA_BUSCTRL_HSIZE_8BIT (0 << 1) /* 8-bit data tranfer */= >=20 > WARNING: 'tranfer' may be misspelled - perhaps 'transfer'? > #2604: FILE: drivers/usb/gadget/udc/cadence_hsudc_regs.h:273: > +#define HSUDC_DMA_BUSCTRL_HSIZE_16BIT (1 << 1) /* 16-bit data tranfer = */ >=20 > WARNING: 'tranfer' may be misspelled - perhaps 'transfer'? > #2605: FILE: drivers/usb/gadget/udc/cadence_hsudc_regs.h:274: > +#define HSUDC_DMA_BUSCTRL_HSIZE_32BIT (2 << 1) /* 32-bit data tranfer = */ >=20 > WARNING: 'tranfer' may be misspelled - perhaps 'transfer'? > #2607: FILE: drivers/usb/gadget/udc/cadence_hsudc_regs.h:276: > +#define HSUDC_DMA_BUSCTRL_BURST_SINGLE (0 << 4) /* Single tranfer */ >=20 > total: 0 errors, 9 warnings, 2499 lines checked >=20 > Your patch has style problems, please review. >=20 > NOTE: If any of the errors are false positives, please report > them to the maintainer, see CHECKPATCH in MAINTAINERS. >=20 --ge1oeF7Sk9vPPOB16waPPVpmPIMbFgMpS-- --3qf7LJncQmmWijVAtf9HlaCkc9X3PEuOv Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJXRGIwAAoJEHfc29rIyEnRcxMP/0PtYdvBc/1UkzgDqLJjQ5vq PqzDf4f+5ZDL6R6LaswE0hJpypjSGlWM3kcB4tq5nTyOqQzgGOaP4BWx/4jXfG2L T4axkJv5F6BkIbtZd5fhEolUkfbS0MyiQvUwqzLAkDMeiLl3xTK+e4f+ipCrNEyz 2h/CMLvoh2iipOB96lWjMzWZBeuo9gFf0zekSl5WLgOSaiKDRVxYMeUbWQCpet6T PGQ3/gGHvw84JyJEosMKTicPQl6ThYrdqTb8a86CnvObrSEAm2qyVfLX+mjfds4w R6rEf4GzvOBHk+sJSxzFu+L0hb08rvT+gtVyg9epTHaAanSViN7DzliTmTsuSb65 DB9bRZutpu0lIYhxZZA14D2CaQzqfxa6GruQl5bdHBd/f6fbPf39c37D2qxzRxOJ OO0fcBtYfoOiBU4MnrVluzLI10BKqUOzdUKXbd3WNmiDKLtvnMS/3+UrFaOhIPFJ KqFetkm3Zar/YE/OMcPxAGWn/j6AKia7miZ9dOOiGRIXno8NsAchiWF/hKEYyCxr yhBzYGt9iaoEZCn05VeeXi79dYipBI2y7jgz6cJu3S01eQQOWJEEbvopdyawer/D QCFp/ReWO9YP3ajVwONMzH/dH/1Z+TnYPxXaMvcORsI9lmOloga0ivG55f0FN/R3 cUhG/mhWYaHCeSKW55Bu =Yl5y -----END PGP SIGNATURE----- --3qf7LJncQmmWijVAtf9HlaCkc9X3PEuOv--