From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932856AbcEXPHk (ORCPT <rfc822;w@1wt.eu>);
	Tue, 24 May 2016 11:07:40 -0400
Received: from mail-it0-f53.google.com ([209.85.214.53]:35000 "EHLO
	mail-it0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752439AbcEXPHi (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 24 May 2016 11:07:38 -0400
X-Greylist: delayed 386 seconds by postgrey-1.27 at vger.kernel.org; Tue, 24 May 2016 11:07:38 EDT
Subject: Re: [PATCH 1/4] bcache: bch_writeback_thread() is not freezable
To: Jiri Kosina <jikos@kernel.org>
References: <alpine.LNX.2.00.1605241634270.31937@cbobk.fhfr.pm>
Cc: Kent Overstreet <kent.overstreet@gmail.com>,
        Eric Wheeler <bcache@lists.ewheeler.net>, linux-bcache@vger.kernel.org,
        linux-kernel@vger.kernel.org
From: Jens Axboe <axboe@kernel.dk>
Message-ID: <57446CB5.6080203@kernel.dk>
Date: Tue, 24 May 2016 09:01:09 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.8.0
MIME-Version: 1.0
In-Reply-To: <alpine.LNX.2.00.1605241634270.31937@cbobk.fhfr.pm>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 05/24/2016 08:38 AM, Jiri Kosina wrote:
> From: Jiri Kosina <jkosina@suse.cz>
>
> bch_writeback_thread() is calling try_to_freeze(), but that's just an
> expensive no-op given the fact that the thread is not marked freezable.
>
> I/O helper kthreads, exactly such as the bcache writeback thread, actually
> shouldn't be freezable, because they are potentially necessary for
> finalizing the image write-out.

Applied 1-4, thanks Jiri.

-- 
Jens Axboe