From: Adrian Hunter <adrian.hunter@intel.com>
To: Andi Kleen <andi@firstfloor.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: jolsa@kernel.org, linux-kernel@vger.kernel.org,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 1/3] perf pt: Mark PT return events as "return"
Date: Tue, 24 May 2016 22:23:01 +0300 [thread overview]
Message-ID: <5744AA15.8010306@intel.com> (raw)
In-Reply-To: <20160524190507.GX13997@two.firstfloor.org>
On 24/05/2016 10:05 p.m., Andi Kleen wrote:
>>> What about beautifying the sample flags i.e. instead of displaying the
>>> letters interpret them into something more human readable e.g.
>>
>> Looks like a good idea, but can't this be done on top of what he sent?
>
> Yes it both makes sense together.
OK I will look at the patch tomorrow.
It looks like it synths 2 samples for each return (one "branches" and
one "return"), which I would expect would mess up the thread_stack pairing
calls and returns. Did you intend to have 2 samples?
next prev parent reply other threads:[~2016-05-24 19:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-24 0:52 [PATCH 1/3] perf pt: Mark PT return events as "return" Andi Kleen
2016-05-24 0:52 ` [PATCH 2/3] perf util: Move get_main_thread to thread.c Andi Kleen
2016-05-24 14:56 ` Arnaldo Carvalho de Melo
2016-06-02 6:30 ` [tip:perf/core] perf thread: Adopt get_main_thread from db-export.c tip-bot for Andi Kleen
2016-05-24 0:52 ` [PATCH 3/3] perf script: Support callindent Andi Kleen
2016-05-24 14:57 ` [PATCH 1/3] perf pt: Mark PT return events as "return" Arnaldo Carvalho de Melo
2016-05-24 16:26 ` Adrian Hunter
2016-05-24 18:10 ` Arnaldo Carvalho de Melo
2016-05-24 19:05 ` Andi Kleen
2016-05-24 19:23 ` Adrian Hunter [this message]
2016-05-24 19:28 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5744AA15.8010306@intel.com \
--to=adrian.hunter@intel.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox