From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932149AbcEXTXJ (ORCPT ); Tue, 24 May 2016 15:23:09 -0400 Received: from mga03.intel.com ([134.134.136.65]:42192 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932073AbcEXTXG (ORCPT ); Tue, 24 May 2016 15:23:06 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,360,1459839600"; d="scan'208";a="109760618" Subject: Re: [PATCH 1/3] perf pt: Mark PT return events as "return" To: Andi Kleen , Arnaldo Carvalho de Melo References: <1464051145-19968-1-git-send-email-andi@firstfloor.org> <20160524145702.GT8897@kernel.org> <574480AB.2000701@intel.com> <20160524181052.GW8897@kernel.org> <20160524190507.GX13997@two.firstfloor.org> Cc: jolsa@kernel.org, linux-kernel@vger.kernel.org, Andi Kleen From: Adrian Hunter Message-ID: <5744AA15.8010306@intel.com> Date: Tue, 24 May 2016 22:23:01 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160524190507.GX13997@two.firstfloor.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24/05/2016 10:05 p.m., Andi Kleen wrote: >>> What about beautifying the sample flags i.e. instead of displaying the >>> letters interpret them into something more human readable e.g. >> >> Looks like a good idea, but can't this be done on top of what he sent? > > Yes it both makes sense together. OK I will look at the patch tomorrow. It looks like it synths 2 samples for each return (one "branches" and one "return"), which I would expect would mess up the thread_stack pairing calls and returns. Did you intend to have 2 samples?