From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754745AbcEYDhw (ORCPT ); Tue, 24 May 2016 23:37:52 -0400 Received: from regular1.263xmail.com ([211.150.99.133]:48861 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754653AbcEYDhk (ORCPT ); Tue, 24 May 2016 23:37:40 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: wxt@rock-chips.com X-FST-TO: peter@piie.net X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: wxt@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <57451C58.6090808@rock-chips.com> Date: Wed, 25 May 2016 11:30:32 +0800 From: Caesar Wang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Peter Feuerer CC: Javi Merino , edubezval@gmail.com, Heiko Stuebner , dianders@chromium.org, briannorris@google.com, smbarber@google.com, linux-rockchip@lists.infradead.org, cf@rock-chips.com, huangtao@rock-chips.com, dmitry.torokhov@gmail.com, Sascha Hauer , Zhang Rui , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 4/5] thermal: bang-bang governor: act on lower trip boundary References: <20160524130610.GC8979@e104805> <1462268013-14992-1-git-send-email-wxt@rock-chips.com> <1462268013-14992-5-git-send-email-wxt@rock-chips.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016年05月25日 01:34, Peter Feuerer wrote: > Hi, > > 24. Mai 2016 15:06 Uhr, "Javi Merino" schrieb: >> Ccing Peter Feuerer, author of the bang bang governor. >> >> On Tue, May 03, 2016 at 05:33:32PM +0800, Caesar Wang wrote: >> >>> From: Sascha Hauer >>> >>> With interrupt driven thermal zones we pass the lower and upper >>> temperature on which shall be acted, so in the governor we have to act on >>> the exact lower temperature to be consistent. Otherwise an interrupt maybe >>> generated on the exact lower temperature, but the bang bang governor does >>> not react since The polling driven zones have to be one step cooler before >>> the governor reacts. >>> >>> Signed-off-by: Sascha Hauer >>> Signed-off-by: Caesar Wang >>> Cc: Zhang Rui >>> Cc: Eduardo Valentin >>> Cc: linux-pm@vger.kernel.org > Acked-by: Peter Feuerer Okay, thanks your reviewing. :) > > >>> --- >>> >>> Changes in v2: >>> - Update the commit for patch[v2 4/5]. >>> >>> drivers/thermal/gov_bang_bang.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/thermal/gov_bang_bang.c b/drivers/thermal/gov_bang_bang.c >>> index 70836c5..9d1dfea 100644 >>> --- a/drivers/thermal/gov_bang_bang.c >>> +++ b/drivers/thermal/gov_bang_bang.c >>> @@ -59,7 +59,7 @@ static void thermal_zone_trip_update(struct thermal_zone_device *tz, int trip) >>> if (instance->target == 0 && tz->temperature >= trip_temp) >>> instance->target = 1; >>> else if (instance->target == 1 && >>> - tz->temperature < trip_temp - trip_hyst) >>> + tz->temperature <= trip_temp - trip_hyst) >>> instance->target = 0; >>> >>> dev_dbg(&instance->cdev->device, "target=%d\n", >>> -- >>> 1.9.1 >>> >>> -- >>> To unsubscribe from this list: send the line "unsubscribe linux-pm" in >>> the body of a message to majordomo@vger.kernel.org >>> More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- caesar wang | software engineer | wxt@rock-chip.com