From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752795AbcEYHLh (ORCPT ); Wed, 25 May 2016 03:11:37 -0400 Received: from mail-wm0-f50.google.com ([74.125.82.50]:35327 "EHLO mail-wm0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751762AbcEYHLd (ORCPT ); Wed, 25 May 2016 03:11:33 -0400 Subject: Re: [PATCH] lightnvm: clear reserved bit on generic addr To: =?UTF-8?Q?Javier_Gonz=c3=a1lez?= References: <1462968506-9292-1-git-send-email-javier@cnexlabs.com> Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, =?UTF-8?Q?Javier_Gonz=c3=a1lez?= From: =?UTF-8?Q?Matias_Bj=c3=b8rling?= Message-ID: <57455021.6080204@lightnvm.io> Date: Wed, 25 May 2016 09:11:29 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1462968506-9292-1-git-send-email-javier@cnexlabs.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/11/2016 02:08 PM, Javier González wrote: > When an address is converted from device to generic mode, the reserved > bit needs to be cleared in order to signal that the address points to a > flash block, not to a cacheline on the write buffer. > > Signed-off-by: Javier González > --- > include/linux/lightnvm.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/include/linux/lightnvm.h b/include/linux/lightnvm.h > index 45be892..3d2c380 100644 > --- a/include/linux/lightnvm.h > +++ b/include/linux/lightnvm.h > @@ -418,6 +418,9 @@ static inline struct ppa_addr dev_to_generic_addr(struct nvm_dev *dev, > l.g.ch |= (r.ppa >> dev->ppaf.ch_offset) & > (((1 << dev->ppaf.ch_len) - 1)); > > + /* On device side, reserved bit is always 0 */ > + l.g.reserved = 0; > + > return l; > } > > Thanks Javier. Applied for 4.8. I have changed it to l.ppa = 0 and updated the description a bit.