From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752876AbcAQPVW (ORCPT ); Sun, 17 Jan 2016 10:21:22 -0500 Received: from gloria.sntech.de ([95.129.55.99]:33520 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752499AbcAQPVV (ORCPT ); Sun, 17 Jan 2016 10:21:21 -0500 From: Heiko Stuebner To: John Keeping Cc: Mark Yao , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [RFC/PATCH] drm/rockchip: don't wait for vblank if fb hasn't changed Date: Sun, 17 Jan 2016 16:21:08 +0100 Message-ID: <5745581.hZKD3MVpjF@phil> User-Agent: KMail/4.14.10 (Linux/4.3.0-1-amd64; KDE/4.14.14; x86_64; ; ) In-Reply-To: <1452689614-6570-1-git-send-email-john@metanate.com> References: <1452689614-6570-1-git-send-email-john@metanate.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Mittwoch, 13. Januar 2016, 12:53:34 schrieb John Keeping: > As commented in drm_atomic_helper_wait_for_vblanks(), userspace relies > on cursor ioctls being unsynced. Converting the rockchip driver to > atomic has significantly impacted cursor performance by making every > cursor update wait for vblank. > > By skipping the vblank sync when the framebuffer has not changed (as is > done in drm_atomic_helper_wait_for_vblanks()) we can avoid this for the > common case of moving the cursor and only need to delay the cursor ioctl > when the cursor icon changes. > > I originally inserted a check on legacy_cursor_update as well, but that > caused a storm of iommu page faults. I didn't investigate the cause of > those since this change gives enough of a performance improvement for my > use case. > > This is RFC because of that and because the framebuffer_changed() > function is copied from drm_atomic_helper.c as a quick way to test the > result. > > Signed-off-by: John Keeping I've seen the effects now as well after making the atomic parts work on in my devtree - i.e. sluggish cursor movements. This patch fixes that issue, so at least: Tested-by: Heiko Stuebner Right now I still see flickering on animated cursors though (like ones used by KDE), that wasn't present before. Heiko