From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752784AbcEYIBz (ORCPT ); Wed, 25 May 2016 04:01:55 -0400 Received: from smtp2.provo.novell.com ([137.65.250.81]:44680 "EHLO smtp2.provo.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751135AbcEYIBx (ORCPT ); Wed, 25 May 2016 04:01:53 -0400 Subject: Re: [PATCHv3 0/2] target: make location of /var/targets configurable To: Lee Duncan , linux-scsi@vger.kernel.org, nab@linux-iscsi.org, target-devel@vger.kernel.org References: <572FE52C.2030806@suse.com> Cc: linux-kernel@vger.kernel.org, hch@infradead.org, hare@suse.de, agrover@redhat.com, jxm@netiant.com From: Zhu Lingshan Message-ID: <57455BE4.9060503@suse.com> Date: Wed, 25 May 2016 16:01:40 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.0 MIME-Version: 1.0 In-Reply-To: <572FE52C.2030806@suse.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi experts, I think these patches are great, and I am ready to help in user space. Thanks, BR Zhu Lingshan On 05/09/2016 09:17 AM, Lee Duncan wrote: > On 04/14/2016 06:18 PM, Lee Duncan wrote: >> These patches make the location of "/var/target" configurable, >> though it still defauls to "/var/target". >> >> This "target database directory" can only be changed >> after the target_core_mod loads but before any >> fabric drivers are loaded, and must be the pathname >> of an existing directory. >> >> This configuration is accomplished via the configfs >> top-level target attribute "dbroot", i.e. dumping >> out "/sys/kernel/config/target/dbroot" will normally >> return "/var/target". Writing to this attribute >> changes the loation where the kernel looks for the >> target database. >> >> The first patch creates this configurable value for >> the "dbroot", and the second patch modifies users >> of this directory to use this new attribute. >> >> Changes from v2: >> * Add locking around access to target driver list >> >> Changes from v1: >> * Only allow changing target DB root before it >> can be used by others >> * Validate that new DB root is a valid directory >> >> Lee Duncan (2): >> target: make target db location configurable >> target: use new "dbroot" target attribute >> >> drivers/target/target_core_alua.c | 6 ++-- >> drivers/target/target_core_configfs.c | 62 +++++++++++++++++++++++++++++++++++ >> drivers/target/target_core_internal.h | 6 ++++ >> drivers/target/target_core_pr.c | 2 +- >> 4 files changed, 72 insertions(+), 4 deletions(-) >> > Ping?