From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753288AbcEYITt (ORCPT ); Wed, 25 May 2016 04:19:49 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:18518 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752561AbcEYITq (ORCPT ); Wed, 25 May 2016 04:19:46 -0400 X-AuditID: cbfec7f4-f796c6d000001486-bf-5745601d321d Subject: Re: [PATCH 1/3] clk: samsung: exynos5433: prepare for adding CPU clocks To: Bartlomiej Zolnierkiewicz , Sylwester Nawrocki , Tomasz Figa References: <1464095957-25851-1-git-send-email-b.zolnierkie@samsung.com> <1464095957-25851-2-git-send-email-b.zolnierkie@samsung.com> Cc: Michael Turquette , Stephen Boyd , Kukjin Kim , linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org From: Krzysztof Kozlowski Message-id: <5745601C.6000806@samsung.com> Date: Wed, 25 May 2016 10:19:40 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-version: 1.0 In-reply-to: <1464095957-25851-2-git-send-email-b.zolnierkie@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrOLMWRmVeSWpSXmKPExsVy+t/xq7qyCa7hBr+myltsnLGe1eL1C0OL /sevmS02Pb7GavGx5x6rxeVdc9gsZpzfx2Rx8ZSrxeE37awWP850s1is2vWH0YHb4/2NVnaP y329TB47Z91l99i0qpPNY/OSeo++LasYPT5vkgtgj+KySUnNySxLLdK3S+DK6Jvynb1gkVLF 3I/zmBoYp8p0MXJySAiYSLzfMYERwhaTuHBvPVsXIxeHkMBSRonOjptQzjNGiY3XpjGBVAkL BEhsm7kILCEi0McocWJ/ByNEVTujRNuz88wgDrPAb0aJ+9cWgQ1mEzCW2Lx8CRuIzSugJXHt 5l7WLkYODhYBVYn2Ng+QsKhAhMSs7T+YIEoEJX5MvscCYnMKeEocnPyZEaScWUBP4v5FLZAw s4C8xOY1b5knMArMQtIxC6FqFpKqBYzMqxhFU0uTC4qT0nMN9YoTc4tL89L1kvNzNzFCouPL DsbFx6wOMQpwMCrx8AqscwkXYk0sK67MPcQowcGsJMKrEecaLsSbklhZlVqUH19UmpNafIhR moNFSZx37q73IUIC6YklqdmpqQWpRTBZJg5OqQbGiTvnTjjt75Fr5X3ZwvVF6CfFZ86bgi1Y 70xWlji9h6Xb5YZQirYh/5SOfyUb5/F6ZPOFHUyebVhcsGnC65bd/OZp6bOWe4S3/zXTf3vy r3eNdKGa09U9prs3qMnM+NzArHbvhFnnrLtzeu+bfjFQNJS8zrixnXfJxfpFR4V/J/jW+V+s +XldiaU4I9FQi7moOBEA9Ka7UIoCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/24/2016 03:19 PM, Bartlomiej Zolnierkiewicz wrote: > Open-code samsung_cmu_register_one() calls for CMU_APOLLO and > CMU_ATLAS setup code as a preparation for adding CPU clocks > support for Exynos5433. > > There should be no functional change resulting from this patch. > > Cc: Kukjin Kim > CC: Krzysztof Kozlowski > Signed-off-by: Bartlomiej Zolnierkiewicz > --- > drivers/clk/samsung/clk-exynos5433.c | 85 +++++++++++++++++++++++------------- > drivers/clk/samsung/clk.c | 12 ++--- > drivers/clk/samsung/clk.h | 4 ++ > 3 files changed, 65 insertions(+), 36 deletions(-) > > diff --git a/drivers/clk/samsung/clk-exynos5433.c b/drivers/clk/samsung/clk-exynos5433.c > index 128527b..6dd81ed 100644 > --- a/drivers/clk/samsung/clk-exynos5433.c > +++ b/drivers/clk/samsung/clk-exynos5433.c > @@ -11,6 +11,7 @@ > > #include > #include > +#include > > #include > > @@ -3594,23 +3595,35 @@ static struct samsung_gate_clock apollo_gate_clks[] __initdata = { > CLK_IGNORE_UNUSED | CLK_SET_RATE_PARENT, 0), > }; > > -static struct samsung_cmu_info apollo_cmu_info __initdata = { > - .pll_clks = apollo_pll_clks, > - .nr_pll_clks = ARRAY_SIZE(apollo_pll_clks), > - .mux_clks = apollo_mux_clks, > - .nr_mux_clks = ARRAY_SIZE(apollo_mux_clks), > - .div_clks = apollo_div_clks, > - .nr_div_clks = ARRAY_SIZE(apollo_div_clks), > - .gate_clks = apollo_gate_clks, > - .nr_gate_clks = ARRAY_SIZE(apollo_gate_clks), > - .nr_clk_ids = APOLLO_NR_CLK, > - .clk_regs = apollo_clk_regs, > - .nr_clk_regs = ARRAY_SIZE(apollo_clk_regs), > -}; > - > static void __init exynos5433_cmu_apollo_init(struct device_node *np) > { > - samsung_cmu_register_one(np, &apollo_cmu_info); > + void __iomem *reg_base; > + struct samsung_clk_provider *ctx; > + > + reg_base = of_iomap(np, 0); > + if (!reg_base) { > + panic("%s: failed to map registers\n", __func__); > + return; > + } > + > + ctx = samsung_clk_init(np, reg_base, APOLLO_NR_CLK); > + if (!ctx) { > + panic("%s: unable to allocate ctx\n", __func__); > + return; > + } > + > + samsung_clk_register_pll(ctx, apollo_pll_clks, > + ARRAY_SIZE(apollo_pll_clks), reg_base); > + samsung_clk_register_mux(ctx, apollo_mux_clks, > + ARRAY_SIZE(apollo_mux_clks)); > + samsung_clk_register_div(ctx, apollo_div_clks, > + ARRAY_SIZE(apollo_div_clks)); > + samsung_clk_register_gate(ctx, apollo_gate_clks, > + ARRAY_SIZE(apollo_gate_clks)); > + samsung_clk_sleep_init(reg_base, apollo_clk_regs, > + ARRAY_SIZE(apollo_clk_regs)); > + > + samsung_clk_of_add_provider(np, ctx); > } > CLK_OF_DECLARE(exynos5433_cmu_apollo, "samsung,exynos5433-cmu-apollo", > exynos5433_cmu_apollo_init); > @@ -3806,23 +3819,35 @@ static struct samsung_gate_clock atlas_gate_clks[] __initdata = { > CLK_IGNORE_UNUSED | CLK_SET_RATE_PARENT, 0), > }; > > -static struct samsung_cmu_info atlas_cmu_info __initdata = { > - .pll_clks = atlas_pll_clks, > - .nr_pll_clks = ARRAY_SIZE(atlas_pll_clks), > - .mux_clks = atlas_mux_clks, > - .nr_mux_clks = ARRAY_SIZE(atlas_mux_clks), > - .div_clks = atlas_div_clks, > - .nr_div_clks = ARRAY_SIZE(atlas_div_clks), > - .gate_clks = atlas_gate_clks, > - .nr_gate_clks = ARRAY_SIZE(atlas_gate_clks), > - .nr_clk_ids = ATLAS_NR_CLK, > - .clk_regs = atlas_clk_regs, > - .nr_clk_regs = ARRAY_SIZE(atlas_clk_regs), > -}; > - > static void __init exynos5433_cmu_atlas_init(struct device_node *np) > { > - samsung_cmu_register_one(np, &atlas_cmu_info); > + void __iomem *reg_base; > + struct samsung_clk_provider *ctx; > + > + reg_base = of_iomap(np, 0); > + if (!reg_base) { > + panic("%s: failed to map registers\n", __func__); > + return; Return is useless here. > + } > + > + ctx = samsung_clk_init(np, reg_base, ATLAS_NR_CLK); > + if (!ctx) { > + panic("%s: unable to allocate ctx\n", __func__); > + return; > + } This entire if() is useless. The samsung_clk_init() already panics. I recently tried to make it consistent across our drivers: http://www.spinics.net/lists/arm-kernel/msg503014.html Beside that, looks fine. Best regards, Krzysztof