From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Russell King <linux@armlinux.org.uk>,
Stefano Stabellini <sstabellini@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>, Joerg Roedel <joro@8bytes.org>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org,
iommu@lists.linux-foundation.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [PATCH 0/4] dma-mapping: Constify dma_attrs
Date: Wed, 25 May 2016 14:37:13 +0200 [thread overview]
Message-ID: <57459C79.8060204@samsung.com> (raw)
In-Reply-To: <20160524090938.GA13166@infradead.org>
On 05/24/2016 11:09 AM, Christoph Hellwig wrote:
> I think this is moving into the wrong direction. The right fix here
> is to get of all the dma_attrs boilerplate code and just replace it
> with a simple enum dma_flags. This would simplify both the callers
> and most importantly the wrappers for the flag-less versions a lot.
The dma attrs are additive so maybe not an enum but an unsigned long and
#defines:
#define DMA_ATTR_WRITE_BARRIER 0x0001u
#define DMA_ATTR_WEAK_ORDERING 0x0002u
#define DMA_ATTR_WRITE_COMBINE 0x0004u
...
The intrusiveness of it would be similar but indeed looks simpler - when
reading the code and when setting the dma_attrs.
If that seems reasonable, I will send a follow up with new approach.
Thanks for feedback!
Best regards,
Krzysztof
prev parent reply other threads:[~2016-05-25 12:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-24 6:28 [PATCH 0/4] dma-mapping: Constify dma_attrs Krzysztof Kozlowski
2016-05-24 6:28 ` [PATCH 1/4] dma-mapping: Constify attrs passed to dma_get_attr Krzysztof Kozlowski
2016-05-24 6:28 ` [PATCH 2/4] ARM: dma-mapping: Constify attrs passed to internal functions Krzysztof Kozlowski
2016-05-24 8:35 ` Russell King - ARM Linux
2016-05-24 6:28 ` [PATCH 3/4] arm64: " Krzysztof Kozlowski
2016-05-24 6:28 ` [RFC 4/4] dma-mapping: Constify dma_attrs Krzysztof Kozlowski
2016-05-24 9:09 ` [PATCH 0/4] " Christoph Hellwig
2016-05-25 12:37 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57459C79.8060204@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=b.zolnierkie@samsung.com \
--cc=catalin.marinas@arm.com \
--cc=hch@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=m.szyprowski@samsung.com \
--cc=sstabellini@kernel.org \
--cc=will.deacon@arm.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox