From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754434AbcEYMhV (ORCPT <rfc822;w@1wt.eu>);
	Wed, 25 May 2016 08:37:21 -0400
Received: from mailout2.w1.samsung.com ([210.118.77.12]:61464 "EHLO
	mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751127AbcEYMhT (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 25 May 2016 08:37:19 -0400
X-AuditID: cbfec7f4-f796c6d000001486-0d-57459c7be3b3
Subject: Re: [PATCH 0/4] dma-mapping: Constify dma_attrs
To: Christoph Hellwig <hch@infradead.org>
References: <1464071290-15948-1-git-send-email-k.kozlowski@samsung.com>
 <20160524090938.GA13166@infradead.org>
Cc: Russell King <linux@armlinux.org.uk>,
        Stefano Stabellini <sstabellini@kernel.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will.deacon@arm.com>, Joerg Roedel <joro@8bytes.org>,
        Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        xen-devel@lists.xenproject.org, iommu@lists.linux-foundation.org,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
X-Enigmail-Draft-Status: N1110
Message-id: <57459C79.8060204@samsung.com>
Date: Wed, 25 May 2016 14:37:13 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.8.0
MIME-version: 1.0
In-reply-to: <20160524090938.GA13166@infradead.org>
Content-type: text/plain; charset=windows-1252
Content-transfer-encoding: 7bit
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrDIsWRmVeSWpSXmKPExsVy+t/xq7rVc1zDDTau5rCYs34Nm8XGGetZ
	Ld4v62G0OD1hEZPFgv3WFp2zN7BbvH5haLFs8VNGi02Pr7FaXN41h83i0NS9jBZrj9xlt1i9
	Lt7i5ccTLBbft0xmcuD3eHJwHpPHmnlrGD0uX7vI7LF5hZbHplWdbB4nZvxm8di8pN5j8o3l
	jB6HP1xh8fj49BaLR9+WVYwenzfJBfBEcdmkpOZklqUW6dslcGXs7D7CWrCIrWLq1a1sDYzN
	rF2MnBwSAiYSR2edYoawxSQu3FvPBmILCSxllFh+S7+LkQvIfsYocfnsarAGYQELiasTLzKC
	2CICmhK3lrczQzQUSGyZeJYRpIFZYCaLRMODE2BFbALGEpuXL2GD2CAn0ds9iQXE5hXQklh0
	5iCYzSKgKnHuwVGwGlGBCIlZ238wQdQISvyYfA+shhNozvQPk4CWcQAt0JO4f1ELJMwsIC+x
	ec1b5gmMgrOQdMxCqJqFpGoBI/MqRtHU0uSC4qT0XEO94sTc4tK8dL3k/NxNjJA4/LKDcfEx
	q0OMAhyMSjy8AutcwoVYE8uKK3MPMUpwMCuJ8BrOdg0X4k1JrKxKLcqPLyrNSS0+xCjNwaIk
	zjt31/sQIYH0xJLU7NTUgtQimCwTB6dUA2OZWbzGrmaNDiuD2/8stUNt5jq8X2y/QUbx0Z18
	np/sjUFac0yeL8zasVlzwyGWr9zrN3pLJ1n1mde1JijmrVCfEHzo9meWqqSib7r3nkRMusja
	eknnUo7E+9yDS79LBGjsWyvJfO7wrxsnuzeaqkjIJC6Od9wXYXo/V4m7XeT0myNCy49yTFZi
	Kc5INNRiLipOBAAGNsOuvwIAAA==
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 05/24/2016 11:09 AM, Christoph Hellwig wrote:
> I think this is moving into the wrong direction.  The right fix here
> is to get of all the dma_attrs boilerplate code and just replace it
> with a simple enum dma_flags.  This would simplify both the callers
> and most importantly the wrappers for the flag-less versions a lot.

The dma attrs are additive so maybe not an enum but an unsigned long and
#defines:

#define	DMA_ATTR_WRITE_BARRIER		0x0001u
#define DMA_ATTR_WEAK_ORDERING		0x0002u
#define DMA_ATTR_WRITE_COMBINE		0x0004u
...

The intrusiveness of it would be similar but indeed looks simpler - when
reading the code and when setting the dma_attrs.

If that seems reasonable, I will send a follow up with new approach.

Thanks for feedback!

Best regards,
Krzysztof