From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932702AbcEYQLO (ORCPT <rfc822;w@1wt.eu>);
	Wed, 25 May 2016 12:11:14 -0400
Received: from arroyo.ext.ti.com ([198.47.19.12]:39792 "EHLO arroyo.ext.ti.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S932412AbcEYQLL (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 25 May 2016 12:11:11 -0400
Subject: Re: [PATCH 0/2] arm: dra7: Add i2c6 instance hwmod and dt entries
To: Ravikumar Kattekola <rk@ti.com>, <paul@pwsan.com>, <tony@atomide.com>,
        <linux@armlinux.org.uk>, <robh+dt@kernel.org>, <pawel.moll@arm.com>,
        <mark.rutland@arm.com>, <ijc+devicetree@hellion.org.uk>,
        <galak@codeaurora.org>, <linux-omap@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>
References: <20160525125341.10044-1-rk@ti.com>
CC: Felipe Balbi <balbi@kernel.org>
From: Nishanth Menon <nm@ti.com>
Message-ID: <5745CE4E.3020903@ti.com>
Date: Wed, 25 May 2016 11:09:50 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.8.0
MIME-Version: 1.0
In-Reply-To: <20160525125341.10044-1-rk@ti.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 05/25/2016 07:53 AM, Ravikumar Kattekola wrote:
> DRA72x devices have a sixth i2c ocntroller instance.
> Following patches add the required hwmod structure and
> device tree nodes.
> 
> Reference doc: DRA72x TRM [ SPRUHP2Q ]
> 
> Tested on :
> DRA72x Rev B EVM
> 
> Ravikumar Kattekola (2):
>   arm: dra7: Add hwmod entry for i2c6
>   dts: dra7: Add device tree node for i2c6
> 
>  arch/arm/boot/dts/dra7.dtsi               | 11 +++++++++++
>  arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 23 +++++++++++++++++++++++
>  2 files changed, 34 insertions(+)
> 
NAK. reasoning:
a) i2c6 is a custom IP integration with completely non-standard
dependencies with cross device dependencies for pretty much a specific
usecase -> usage is pretty much limited for generic support - the
decision is NOT to support this instance in Linux kernel - internal
discussion forwarded to developer.
b) the patches themselves are wrong -> it applies to DRA72x not
generic DRA7x platform
c) patches themselves are in the wrong format (wrong subject line etc).
d) patches don't handle the SoC internal device dependencies either ->
in short will not function in a generic solution for all variations of
platforms.

-- 
Regards,
Nishanth Menon