From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C106D19B3D8 for ; Thu, 31 Oct 2024 13:34:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730381647; cv=none; b=Ca52FfhiVerWLU/DLRcnO/lmq0+UxobQBN5z/njYA+QWl3Te3l+XjmVkdeCw4IFP5oGpTs85Pg5A4EV/JkDIt54oy35awWBus1+uun5tPaVnVa71+bug4SVfSrHqiGgUCNiTQwG3da3KtxWrfS9+4tfRJ0lglBTbK2kX8eq7l28= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730381647; c=relaxed/simple; bh=lHlVuwc9yKhhTdvAgJ7M5o7k87Io2woWjcJIqYmQghg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Zn5u5vFftTScC/SKOurXA0fc6ViZXy1jPVNBIDs5nMw6ws+8yIygNS1E+EeUhikq75hcOTKOW5ijM25nQcohdWnbelxa5tL/H4NR9h15jUCh7Ekw3zNbCqD8mDpxDNnJKBi86VYfJzs6256Ce0BIIZZ95zR+mXTutduRG8iiXD4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=DJKN8wop; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="DJKN8wop" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1730381642; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=DfVritWC7IRKAQiQlgAVdrxgfoMbtuoscnWLde6VVP4=; b=DJKN8wop+nTzNsNO5fzCuCC2+r2JiOKgrxiQfDmF2d6Wkp9XHWIv60uY+3I4nXXWfhuO6K yJc2NNe6JWeBTIYc3hrzieud/f8cxy1UEfETvH3kc7zq+JQiS6vikNpjX0VHeQc4WPB9Ip FoK/2Y8fzrdODol9Afp10TlaNbYb2kw= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-277-nZ0L1kRmMISNfQBXYnoF0g-1; Thu, 31 Oct 2024 09:34:00 -0400 X-MC-Unique: nZ0L1kRmMISNfQBXYnoF0g-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4327bd6bd60so6183485e9.1 for ; Thu, 31 Oct 2024 06:34:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730381639; x=1730986439; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=DfVritWC7IRKAQiQlgAVdrxgfoMbtuoscnWLde6VVP4=; b=K5mRjEvCdu0V5TadhgwGGF1V8rNiXjdIy2yBjQQ78DmeHzr7xpnjTKvDHH8Hrq1acs 9TqLeAQaaVMAhWMYx4bmFbUqNRSzsXTqq7NFHSRuELL3CXHFaJx31zW5BAxo02PNTHnT UH5pN0/9HFWM74XCFnG6xDLkHIqObq9AuYJGYy62bPmUDXgeYfoMd7Y5DNudVEbzsJ+m 0Or9ujCY+zWTVGF5SS2PF8cwj2Cws/TQ9bRYwdaH29itbwW14pcvSqAt/MSr7BrjW2le 8M9e2da+2QJ3mhE0TiWhfN+Yag1GXxLlJkaP18Lh+caNJyju36Rpsl0HfiwzX5VTsjoc qIhg== X-Forwarded-Encrypted: i=1; AJvYcCWSMWXo9irqtmmqRdwNW0u0n32vsOpt3wzvQ2UTcJhb6R60l5tXl8g7btGJRh+zosje01rhQ2fs6wgS9BQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwVcSWWD0NmLQtVQwFm3iaRMG49VAkBc0LygM+xORzHmK+LYv42 LAxNCf/r/Z7D5SOa9txhc9oThBQOYE6WOub5npQzXC/ZPKF8MTWUh9qTnUwDmqzB2UsrVU1MqPx 3fnrjKKhVx5WDsEl277q3GEpHtrnMAqqatakHTDYaAtxIbpee0TslJVW3QXo/uw== X-Received: by 2002:a05:600c:1c01:b0:431:12a8:7f1a with SMTP id 5b1f17b1804b1-4319acadc13mr189866015e9.16.1730381639169; Thu, 31 Oct 2024 06:33:59 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF+gPPe3ew7+y1OLC57nwOwBccPCqhXN51sYPcz2OwDjQcaOxZQW4t1gXnP/zgP1MKCnzV/dg== X-Received: by 2002:a05:600c:1c01:b0:431:12a8:7f1a with SMTP id 5b1f17b1804b1-4319acadc13mr189865755e9.16.1730381638730; Thu, 31 Oct 2024 06:33:58 -0700 (PDT) Received: from ?IPV6:2003:cb:c70a:ed00:7ddf:1ea9:4f7a:91fe? (p200300cbc70aed007ddf1ea94f7a91fe.dip0.t-ipconnect.de. [2003:cb:c70a:ed00:7ddf:1ea9:4f7a:91fe]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-431bd947c26sm57601345e9.26.2024.10.31.06.33.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 31 Oct 2024 06:33:56 -0700 (PDT) Message-ID: <5745d2ca-4d87-4d1f-b38f-734c7086f462@redhat.com> Date: Thu, 31 Oct 2024 14:33:55 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/4] mm: shmem: override mTHP shmem default with a kernel parameter To: =?UTF-8?Q?Ma=C3=ADra_Canal?= , Jonathan Corbet , Andrew Morton , Hugh Dickins , Barry Song , Ryan Roberts , Baolin Wang , Lance Yang Cc: linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-dev@igalia.com References: <20241030130308.1066299-1-mcanal@igalia.com> <20241030130308.1066299-4-mcanal@igalia.com> <2c507326-3267-431e-936a-23e2ab6a3baf@redhat.com> <899284fa-953f-48a1-af29-222d0d55881c@igalia.com> <95c48a30-0696-4110-950e-e81afb4ffc2a@igalia.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <95c48a30-0696-4110-950e-e81afb4ffc2a@igalia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 31.10.24 14:24, Maíra Canal wrote: > Hi David, > > On 31/10/24 09:57, David Hildenbrand wrote: >> On 31.10.24 13:51, Maíra Canal wrote: >>> Hi David, >>> >>> On 31/10/24 09:37, David Hildenbrand wrote: >>>> On 30.10.24 13:58, Maíra Canal wrote: >>>>> Add the ``thp_shmem=`` kernel command line to allow specifying the >>>>> default policy of each supported shmem hugepage size. The kernel >>>>> parameter >>>>> accepts the following format: >>>>> >>>>> thp_shmem=[KMG],[KMG]:;[KMG]- >>>>> [KMG]: >>>>> >>>>> For example, >>>>> >>>>> thp_shmem=16K-64K:always;128K,512K:inherit;256K:advise;1M-2M:never;4M-8M:within_size >>>>> >>>>> By configuring the default policy of several shmem hugepages, the user >>>>> can take advantage of mTHP before it's been configured through sysfs. >>>>> >>>>> Signed-off-by: Maíra Canal >>>>> --- >>>>>    .../admin-guide/kernel-parameters.txt         |  10 ++ >>>>>    Documentation/admin-guide/mm/transhuge.rst    |  17 +++ >>>>>    mm/shmem.c                                    | 109 +++++++++++++ >>>>> ++++- >>>>>    3 files changed, 135 insertions(+), 1 deletion(-) >>>>> >>> >>> [...] >>> >>>>> diff --git a/mm/shmem.c b/mm/shmem.c >>>>> index dfcc88ec6e34..c2299fa0b345 100644 >>>>> --- a/mm/shmem.c >>>>> +++ b/mm/shmem.c >>>>> @@ -136,6 +136,7 @@ static unsigned long huge_shmem_orders_always >>>>> __read_mostly; >>>>>    static unsigned long huge_shmem_orders_madvise __read_mostly; >>>>>    static unsigned long huge_shmem_orders_inherit __read_mostly; >>>>>    static unsigned long huge_shmem_orders_within_size __read_mostly; >>>>> +static bool shmem_orders_configured __initdata; >>>>>    #endif >>>>>    #ifdef CONFIG_TMPFS >>>>> @@ -5027,7 +5028,8 @@ void __init shmem_init(void) >>>>>         * Default to setting PMD-sized THP to inherit the global >>>>> setting and >>>>>         * disable all other multi-size THPs. >>>>>         */ >>>>> -    huge_shmem_orders_inherit = BIT(HPAGE_PMD_ORDER); >>>>> +    if (!shmem_orders_configured) >>>>> +        huge_shmem_orders_inherit = BIT(HPAGE_PMD_ORDER); >>>>>    #endif >>>>>        return; >>>>> @@ -5180,6 +5182,26 @@ struct kobj_attribute >>>>> thpsize_shmem_enabled_attr = >>>>>    #if defined(CONFIG_TRANSPARENT_HUGEPAGE) >>>>> +static inline int get_order_from_str(const char *size_str) >>>>> +{ >>>>> +    unsigned long size; >>>>> +    char *endptr; >>>>> +    int order; >>>>> + >>>>> +    size = memparse(size_str, &endptr); >>>>> + >>>>> +    if (!is_power_of_2(size)) >>>>> +        goto err; >>>>> +    order = get_order(size); >>>>> +    if (BIT(order) & ~THP_ORDERS_ALL_FILE_DEFAULT) >>>>> +        goto err; >>>>> + >>>>> +    return order; >>>>> +err: >>>>> +    pr_err("invalid size %s in thp_shmem boot parameter\n", size_str); >>>>> +    return -EINVAL; >>>>> +} >>>> >>>> Hm, mostly copy and paste. You could reuse existing get_order_from_str() >>>> simply by passing in the supported orders and moving error reporting to >>>> the caller. >>>> >>> >>> Can I use functions from mm/huge_memory.c here? >> >> Yes, that's the idea. >> > > Unfortunately, it isn't possible without adding the function to a > header. Well ... sure, what's the problem with that? -- Cheers, David / dhildenb