From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751537AbcEYUoc (ORCPT ); Wed, 25 May 2016 16:44:32 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:37104 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751110AbcEYUoa (ORCPT ); Wed, 25 May 2016 16:44:30 -0400 Subject: Re: [PATCH] PCI/ASPM: fix reverse ASPM L0s assignment of upstream and downstream To: Bjorn Helgaas References: <1464071269-79954-1-git-send-email-hehy1@lenovo.com> <20160525165726.GB3208@localhost> <5745DF08.9040409@codeaurora.org> <20160525175039.GC3208@localhost> <5745EC95.1020506@codeaurora.org> <20160525183316.GD3208@localhost> Cc: Ocean HY1 He , "bhelgaas@google.com" , "wangyijing@huawei.com" , "luto@kernel.org" , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "prarit@redhat.com" , "jcm@redhat.com" , Nagananda Chumbalkar From: Sinan Kaya Message-ID: <57460EAA.9040705@codeaurora.org> Date: Wed, 25 May 2016 16:44:26 -0400 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <20160525183316.GD3208@localhost> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/25/2016 2:33 PM, Bjorn Helgaas wrote: > It looks like the code enforces this by clearing bits in > link->aspm_capable (effectively pretending L0s or L1 are unsupported) > if the latency is too high. Yes, this is what I was referring to. I think what Linux does is the right thing. -- Sinan Kaya Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project