From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751923AbcEYVsM (ORCPT ); Wed, 25 May 2016 17:48:12 -0400 Received: from lists.s-osg.org ([54.187.51.154]:45285 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751250AbcEYVsL (ORCPT ); Wed, 25 May 2016 17:48:11 -0400 Message-ID: <57461D94.1030403@osg.samsung.com> Date: Wed, 25 May 2016 22:48:04 +0100 From: Luis de Bethencourt User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.8.0 MIME-Version: 1.0 To: Daeseok Youn , lidza.louina@gmail.com CC: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, driverdev-devel@linuxdriverproject.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] staging: dgnc: remove redundant NULL check for brd References: <20160520095104.GA30075@SEL-JYOUN-D1> In-Reply-To: <20160520095104.GA30075@SEL-JYOUN-D1> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20/05/16 10:51, Daeseok Youn wrote: > the "brd" value cannot be NULL in dgnc_finalize_board_init(). > Because "brd" as a parameter of this function was already > checked for NULL. > > Signed-off-by: Daeseok Youn > --- > drivers/staging/dgnc/dgnc_driver.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/staging/dgnc/dgnc_driver.c b/drivers/staging/dgnc/dgnc_driver.c > index af2e835..22257d2 100644 > --- a/drivers/staging/dgnc/dgnc_driver.c > +++ b/drivers/staging/dgnc/dgnc_driver.c > @@ -579,9 +579,6 @@ static int dgnc_finalize_board_init(struct dgnc_board *brd) > { > int rc = 0; > > - if (!brd || brd->magic != DGNC_BOARD_MAGIC) > - return -ENODEV; > - > if (brd->irq) { > rc = request_irq(brd->irq, brd->bd_ops->intr, > IRQF_SHARED, "DGNC", brd); > This is partially correct, the check for brd being NULL is in line 371. But there is a second check for brd->magic != DGNC_BOARD_MAGIC. Do you want to keep that one? Also, how did you find this patch. It is useful to mention this in the commit message if it was through some static analysis tool. For people using these tools in the future. Thanks for the patch :) Luis