From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753265AbcEZJFF (ORCPT ); Thu, 26 May 2016 05:05:05 -0400 Received: from regular1.263xmail.com ([211.150.99.140]:44003 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751100AbcEZJFC (ORCPT ); Thu, 26 May 2016 05:05:02 -0400 X-263anti-spam: KSV:0;BIG:0;ABS:1;DNS:0;ATT:0;SPF:S; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ADDR-CHECKED: 0 X-RL-SENDER: zhengxing@rock-chips.com X-FST-TO: alsa-devel@alsa-project.org X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: zhengxing@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [RESEND PATCH v2] ASoC: rockchip: Add machine driver for MAX98357A/RT5514/DA7219 To: Rob Herring References: <1464053774-15914-1-git-send-email-zhengxing@rock-chips.com> <20160525173246.GA5125@rob-hp-laptop> Cc: linux-rockchip@lists.infradead.org, dianders@chromium.org, heiko@sntech.de, Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org From: Xing Zheng Message-ID: <5746BC27.1030008@rock-chips.com> Date: Thu, 26 May 2016 17:04:39 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160525173246.GA5125@rob-hp-laptop> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rob, On 2016年05月26日 01:32, Rob Herring wrote: > On Tue, May 24, 2016 at 09:36:14AM +0800, Xing Zheng wrote: >> There are multi codec devices on the RK3399 platform, we can use >> this patch support and control these codecs. >> >> Signed-off-by: Xing Zheng >> --- >> >> Changes in v2: >> - use the FS 256 to set mclks of the max98357a and rt5514 danamically >> - add more sample rate for da7219 >> >> .../sound/rockchip-max98357a-rt5514-da7219.txt | 15 + >> sound/soc/rockchip/Kconfig | 11 + >> sound/soc/rockchip/Makefile | 2 + >> .../rockchip/rockchip_max98357a_rt5514_da7219.c | 333 ++++++++++++++++++++ >> 4 files changed, 361 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/sound/rockchip-max98357a-rt5514-da7219.txt >> create mode 100644 sound/soc/rockchip/rockchip_max98357a_rt5514_da7219.c >> >> diff --git a/Documentation/devicetree/bindings/sound/rockchip-max98357a-rt5514-da7219.txt b/Documentation/devicetree/bindings/sound/rockchip-max98357a-rt5514-da7219.txt >> new file mode 100644 >> index 0000000..5928384 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/sound/rockchip-max98357a-rt5514-da7219.txt >> @@ -0,0 +1,15 @@ >> +ROCKCHIP with MAX98357A/RT5514/DA7219 codecs >> + >> +Required properties: >> +- compatible: "rockchip,rockchip-sound" > This is generic, but the binding seems to be very specific to only 3 > specific codecs. Listing all 3 codecs seems a bit strange. Perhaps a > name related to the board name would be better. Yes, I think that I should rename to rk3399_max98357a_rt5514_da7219.c, it is related to the rk3399 boards. >> +- rockchip,cpu: The phandle of the Rockchip I2S controller that's >> + connected to the codecs > What's the size? always 3? Not always 3, the size is limited by machine driver, The similar approach with mt8173-rt5650-rt5676.txt. >> +- rockchip,codec: The phandle of the MAX98357A/RT5514/DA7219 codecs > Please make the size and ordering clear. Ditto. Thanks. -- - Xing Zheng