From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753607AbcEZKcq (ORCPT <rfc822;w@1wt.eu>);
	Thu, 26 May 2016 06:32:46 -0400
Received: from smtp.citrix.com ([66.165.176.89]:48347 "EHLO SMTP.CITRIX.COM"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751355AbcEZKco (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 26 May 2016 06:32:44 -0400
X-IronPort-AV: E=Sophos;i="5.26,367,1459814400"; 
   d="scan'208";a="356766347"
Subject: Re: [Xen-devel] [PATCH] xen: remove incorrect forward declaration
To: Arnd Bergmann <arnd@arndb.de>, David Vrabel <david.vrabel@citrix.com>
References: <1462972075-918938-1-git-send-email-arnd@arndb.de>
CC: Juergen Gross <jgross@suse.com>,
        Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
        Daniel Kiper <daniel.kiper@oracle.com>,
        Paul Gortmaker <paul.gortmaker@windriver.com>,
        <linux-kernel@vger.kernel.org>, <stable@vger.kernel.org>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Julien Grall <julien.grall@citrix.com>,
        Ross Lagerwall <ross.lagerwall@citrix.com>,
        <xen-devel@lists.xenproject.org>,
        "Boris Ostrovsky" <boris.ostrovsky@oracle.com>,
        Andrew Morton <akpm@linux-foundation.org>
From: David Vrabel <david.vrabel@citrix.com>
Message-ID: <5746D0C8.7000801@citrix.com>
Date: Thu, 26 May 2016 11:32:40 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Icedove/38.5.0
MIME-Version: 1.0
In-Reply-To: <1462972075-918938-1-git-send-email-arnd@arndb.de>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
X-DLP: MIA2
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/05/16 14:07, Arnd Bergmann wrote:
> A bugfix patch for the xen balloon driver introduced a forward
> declaration for a static function that is conditionally compiled,
> causing a warning if only the declaration but not the definition
> are there:
> 
> drivers/xen/balloon.c:154:13: error: 'release_memory_resource' declared 'static' but never defined [-Werror=unused-function]
>  static void release_memory_resource(struct resource *resource);
> 
> This removes the declaration again and instead moves the function
> definition to the right place, before its first caller and inside
> of the #ifdef protecting both.

I've applied the equivalent patch from Ross, instead.

> The patch that introduced the warning is marked for stable
> backports, so if that gets applied to 4.4, so should this one.

Fixes for compiler warnings are not sufficiently important to be
backported to stable.

David