From: Luis de Bethencourt <luisbg@osg.samsung.com>
To: Shubham Bansal <illusionist.neo@gmail.com>,
gregkh@linuxfoundation.org, arve@android.com,
riandrews@android.com, labbott@redhat.com, rohit.kr@samsung.com,
gioh.kim@lge.com, daniel.vetter@ffwll.ch,
kirill.shutemov@linux.intel.com, shawn.lin@rock-chips.com,
dy@drexel.edu, neilzhang1123@hotmail.com,
eun.taik.lee@samsung.com, sriram@marirs.net.in,
tiago.vignatti@intel.com
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: android: ion: fixed a kzalloc coding style issue.
Date: Thu, 26 May 2016 13:35:59 +0100 [thread overview]
Message-ID: <5746EDAF.7010902@osg.samsung.com> (raw)
In-Reply-To: <1464249674-7812-1-git-send-email-illusionist.neo@gmail.com>
On 26/05/16 09:01, Shubham Bansal wrote:
> Fixed a coding style issue. Issue reported by checkpatch.pl.
>
> Signed-off-by: Shubham Bansal <illusionist.neo@gmail.com>
> ---
> drivers/staging/android/ion/ion.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c
> index 8536567..2217ccb 100644
> --- a/drivers/staging/android/ion/ion.c
> +++ b/drivers/staging/android/ion/ion.c
> @@ -184,7 +184,7 @@ static struct ion_buffer *ion_buffer_create(struct ion_heap *heap,
> struct scatterlist *sg;
> int i, ret;
>
> - buffer = kzalloc(sizeof(struct ion_buffer), GFP_KERNEL);
> + buffer = kzalloc(sizeof(*buffer), GFP_KERNEL);
> if (!buffer)
> return ERR_PTR(-ENOMEM);
>
>
This patch looks good.
It is not a big issue, but have it in mind for the future. When fixing issues
reported by checkpatch, it is nice to paste the output warning of checkpatch
in the commit message.
Look at this example:
https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=e7a142aaa09fa5db015fd176d6943f888665829f
Thanks,
Luis
next prev parent reply other threads:[~2016-05-26 12:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-26 8:01 [PATCH] Staging: android: ion: fixed a kzalloc coding style issue Shubham Bansal
2016-05-26 12:35 ` Luis de Bethencourt [this message]
2016-08-15 14:51 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2016-05-15 1:26 Shubham Bansal
2016-08-15 14:49 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5746EDAF.7010902@osg.samsung.com \
--to=luisbg@osg.samsung.com \
--cc=arve@android.com \
--cc=daniel.vetter@ffwll.ch \
--cc=devel@driverdev.osuosl.org \
--cc=dy@drexel.edu \
--cc=eun.taik.lee@samsung.com \
--cc=gioh.kim@lge.com \
--cc=gregkh@linuxfoundation.org \
--cc=illusionist.neo@gmail.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=labbott@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=neilzhang1123@hotmail.com \
--cc=riandrews@android.com \
--cc=rohit.kr@samsung.com \
--cc=shawn.lin@rock-chips.com \
--cc=sriram@marirs.net.in \
--cc=tiago.vignatti@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox