From: Stephen Warren <swarren@wwwdotorg.org>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Peter Chen <Peter.Chen@nxp.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alexandre Courbot <gnurou@gmail.com>,
Jon Hunter <jonathanh@nvidia.com>,
linux-usb@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC 1/5] usb: chipidea: Add support for Tegra20/30/114/124
Date: Thu, 26 May 2016 15:17:12 -0600 [thread overview]
Message-ID: <574767D8.8020203@wwwdotorg.org> (raw)
In-Reply-To: <20160526154005.11558-2-thierry.reding@gmail.com>
On 05/26/2016 09:40 AM, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> All of these Tegra SoC generations have a ChipIdea UDC IP block that can
> be used for device mode communication with a host. Implement rudimentary
> support that doesn't allow switching between host and device modes.
Are you sure this is correct for Tegra20? I ask because for the /host/
mode driver, there's a "has_hostpc" flag which is set to false for
Tegra20 and true for all other SoCs. In the U-Boot device mode driver
(if not in the kernel driver; I didn't check), there's a concept of "has
hostpc" too. I might expect that flag to be set the same way for both
drivers. That said, I /think/ the host and device HW are unrelated, so
it's possible has_hostpc might be set differently for them.
Unfortunately, we haven't enabled the device mode driver for any Tegra20
system in U-Boot so I can't tell whether we should enable has_hostpc for
Tegra20's device mode driver.
Still, if this code works then I guess it's likely correct...
next prev parent reply other threads:[~2016-05-26 21:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-26 15:40 [RFC 0/5] usb: chipidea: Add support for Tegra20 through Tegra124 Thierry Reding
2016-05-26 15:40 ` [RFC 1/5] usb: chipidea: Add support for Tegra20/30/114/124 Thierry Reding
2016-05-26 21:17 ` Stephen Warren [this message]
2016-05-26 21:22 ` Stephen Warren
2016-05-26 15:40 ` [RFC 2/5] ARM: tegra: Enable UDC on TrimSlice Thierry Reding
2016-05-26 15:40 ` [RFC 3/5] ARM: tegra: Enable UDC on Beaver Thierry Reding
2016-05-26 15:40 ` [RFC 4/5] ARM: tegra: Enable UDC on Dalmore Thierry Reding
2016-05-27 3:18 ` Peter Chen
2016-05-26 15:40 ` [RFC 5/5] ARM: tegra: Enable UDC on Jetson TK1 Thierry Reding
2016-05-27 3:16 ` [RFC 0/5] usb: chipidea: Add support for Tegra20 through Tegra124 Peter Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=574767D8.8020203@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=Peter.Chen@nxp.com \
--cc=gnurou@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox