From: Krzysztof Kozlowski <krzk@kernel.org>
To: Shin Son <shin.son@samsung.com>,
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Zhang Rui <rui.zhang@intel.com>,
Lukasz Luba <lukasz.luba@arm.com>, Rob Herring <robh@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Henrik Grimler <henrik@grimler.se>
Cc: linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 1/3] dt-bindings: thermal: samsung: Adjust '#thermal-sensor-cells' to 1
Date: Fri, 10 Oct 2025 14:43:59 +0200 [thread overview]
Message-ID: <5747ce14-2963-4c5f-b43b-5437807cfb11@kernel.org> (raw)
In-Reply-To: <20250930005139.1424963-2-shin.son@samsung.com>
On 30/09/2025 02:51, Shin Son wrote:
> reg:
> minItems: 1
> maxItems: 1
> + '#thermal-sensor-cells':
> + const: 0
> +
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: samsung,exynosautov920-tmu
> + then:
> + properties:
> + clocks:
> + minItems: 1
You can drop minItems. Existing binding has it unnecessarily.
> + maxItems: 1
You also need clock-names restriction, just like clocks or just ": false".
> + reg:
> + minItems: 1
This also drop.
> + maxItems: 1
> + '#thermal-sensor-cells':
> + const: 1
>
Rest looks fine, so with changes above:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-10-10 12:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20250930005147epcas2p36e57d022e5c2df908550b920aafd41c0@epcas2p3.samsung.com>
2025-09-30 0:51 ` [PATCH v6 0/3] Add exynosautov920 thermal support Shin Son
2025-09-30 0:51 ` [PATCH v6 1/3] dt-bindings: thermal: samsung: Adjust '#thermal-sensor-cells' to 1 Shin Son
2025-10-10 12:43 ` Krzysztof Kozlowski [this message]
2025-10-16 5:53 ` 손신
2025-09-30 0:51 ` [PATCH v6 2/3] thermal: exynos_tmu: Support new hardware and update TMU interface Shin Son
2025-09-30 0:51 ` [PATCH v6 3/3] arm64: dts: exynosautov920: Add multiple sensors Shin Son
2025-10-10 12:45 ` Krzysztof Kozlowski
2025-10-16 5:55 ` 손신
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5747ce14-2963-4c5f-b43b-5437807cfb11@kernel.org \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=bzolnier@gmail.com \
--cc=conor+dt@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=henrik@grimler.se \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=rui.zhang@intel.com \
--cc=shin.son@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox